[rkward-cvs] SF.net SVN: rkward:[3008] trunk/rkward/rkward/settings/rksettings.cpp

[tfry at users.sourceforge.net]

Revision: 3008
          http://rkward.svn.sourceforge.net/rkward/?rev=3008&view=rev
Author:   tfry
Date:     2010-09-09 13:52:55 +0000 (Thu, 09 Sep 2010)

Log Message:
-----------
Fix "Help"-button on settings pages (how long has this been broken?).

Modified Paths:
--------------
    trunk/rkward/rkward/settings/rksettings.cpp

Modified: trunk/rkward/rkward/settings/rksettings.cpp
===================================================================
--- trunk/rkward/rkward/settings/rksettings.cpp	2010-09-09 11:25:57 UTC (rev 3007)
+++ trunk/rkward/rkward/settings/rksettings.cpp	2010-09-09 13:52:55 UTC (rev 3008)
@@ -147,12 +147,11 @@
 	} else if (button == KDialog::Cancel) {
 		reject ();
 	} else if (button == KDialog::Help) {
-		int i = 0;
-		for (i = 0; i < NumPages; ++i) {
-			if (currentPage () == pages[i]) break;
+		RKSettingsModule *current_module = dynamic_cast<RKSettingsModule*> (currentPage ()->widget ());
+		if (!current_module) {
+			RK_ASSERT (false);
+			return;
 		}
-		RKSettingsModule *current_module = modules[static_cast<SettingsPage> (i)];
-		RK_ASSERT (current_module);
 	
 		RKWorkplace::mainWorkplace ()->openHelpWindow (current_module->helpURL ());
 	} else {


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.