[rkward-cvs] SF.net SVN: rkward:[2437] trunk/rkward

[tfry at users.sourceforge.net]

Revision: 2437
          http://rkward.svn.sourceforge.net/rkward/?rev=2437&view=rev
Author:   tfry
Date:     2009-03-31 19:52:39 +0000 (Tue, 31 Mar 2009)

Log Message:
-----------
Fix crash when reaching bottom of command history in context sensitive search

Modified Paths:
--------------
    trunk/rkward/ChangeLog
    trunk/rkward/rkward/rkconsole.cpp

Modified: trunk/rkward/ChangeLog
===================================================================
--- trunk/rkward/ChangeLog	2009-03-31 18:53:41 UTC (rev 2436)
+++ trunk/rkward/ChangeLog	2009-03-31 19:52:39 UTC (rev 2437)
@@ -1,3 +1,5 @@
+- Fix crash when reaching bottom of command history in context sensitive search
+		TODO: Backport needed?
 - Fix crash while inserting rows in a data.frame with string variables
 
 --- Version 0.5.0c - Mar-30-2009

Modified: trunk/rkward/rkward/rkconsole.cpp
===================================================================
--- trunk/rkward/rkward/rkconsole.cpp	2009-03-31 18:53:41 UTC (rev 2436)
+++ trunk/rkward/rkward/rkconsole.cpp	2009-03-31 19:52:39 UTC (rev 2437)
@@ -573,8 +573,7 @@
 		return;
 	}
 
-	while (commands_history_position != commands_history.constEnd ()) {
-		++commands_history_position;
+	while (++commands_history_position != commands_history.constEnd ()) {
 		if ((!context_sensitive) || (*commands_history_position).startsWith (command_history_context)) { // we found a match or next line
 			break;
 		}


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.