[rkward-tracker] [ rkward-Bugs-2843290 ] [PATCH] undefined symbols at link time

[SourceForge.net]

Bugs item #2843290, was opened at 2009-08-24 00:36
Message generated for change (Settings changed) made by tfry
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=459007&aid=2843290&group_id=50231

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
>Status: Closed
Resolution: Fixed
Priority: 5
Private: No
Submitted By: Yaakov Selkowitz (yselkowitz)
Assigned to: Thomas Friedrichsmeier (tfry)
Summary: [PATCH] undefined symbols at link time

Initial Comment:
Building 0.5.1 for X11, the link fails due to undefined symbols in rkward.bin which need to be resolved by adding -lX11 (X11_X11_LIB in CMake parlance).  Patch attached.

----------------------------------------------------------------------

>Comment By: Thomas Friedrichsmeier (tfry)
Date: 2009-08-25 17:39

Message:
Thanks for explaining.

Well, again, I've changed this in SVN, so closing the report.

----------------------------------------------------------------------

Comment By: Yaakov Selkowitz (yselkowitz)
Date: 2009-08-25 00:10

Message:
On PE/COFF platforms, such as native Windows/MinGW and Cygwin, all symbols
must be resolved at link time.  ELF binaries do not have this limitation
unless -Wl,--no-undefined (aka -Wl,-z,defs) is used, hence it works
regardless.  

There are explicit calls to XInternAtom and XSelectInput in
rkwardapplication.cpp  (ifndef Q_WS_WIN, of course).  Cygwin is a PE/COFF
platform but uses *NIX/X11 APIs, hence the problem.

(On Linux, there is technically the extra time involved in ld.so resolving
those symbols at runtime, but given that libX11 would already be loaded I
highly doubt that it would be noticeable.)

AFAICS there is no rush to release just for this.

----------------------------------------------------------------------

Comment By: Thomas Friedrichsmeier (tfry)
Date: 2009-08-24 12:00

Message:
Thanks for the patch. Committed to SVN (slightly modified, so -lX11 is not
used on Windows).

While it really is correct to link against X11, this used to work without
explicitly adding -X11, and still does on this system. Could you give some
details on the system(s) where linking fails without this? Depending on
just how common that is, we might need a bugfix release, that's why I'm
asking.

Regards
Thomas



----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=459007&aid=2843290&group_id=50231