[rkward-cvs] SF.net SVN: rkward:[2440] trunk/rkward
tfry at users.sourceforge.net
tfry at users.sourceforge.net
Sun Apr 5 20:49:38 UTC 2009
Revision: 2440
http://rkward.svn.sourceforge.net/rkward/?rev=2440&view=rev
Author: tfry
Date: 2009-04-05 20:49:38 +0000 (Sun, 05 Apr 2009)
Log Message:
-----------
Shut up some warnings on empty parts
Modified Paths:
--------------
trunk/rkward/TODO
trunk/rkward/rkward/misc/CMakeLists.txt
trunk/rkward/rkward/misc/rkdummypart.cpp
trunk/rkward/rkward/windows/rcontrolwindow.cpp
trunk/rkward/rkward/windows/rcontrolwindow.h
Modified: trunk/rkward/TODO
===================================================================
--- trunk/rkward/TODO 2009-04-04 21:38:11 UTC (rev 2439)
+++ trunk/rkward/TODO 2009-04-05 20:49:38 UTC (rev 2440)
@@ -2,16 +2,15 @@
Also, plans change frequently. If something is listed for a specific release, that's no more than a rough plan.
All in all, this TODO list is mostly for internal purposes, and many parts may not necessarily be intellegible to anybody but the authors.
-Important:
- - Around March 1st, write to R-devel to achieve having IS_UTF8 and IS_LATIN1 in public API (if not already available, then).
- - Is Rf_translateChar() what we are looking for?
-
Advertizing:
- start being a bit bolder about RKWard (descriptions, startup notification, etc.)
-Should be done before 0.5.0 release:
- - document building with KDE 4 in wiki / web
- - adjust debian dir?
+Bugs outside RKWard:
+ - KDE 4
+ - KPageDialog does not take all pages into acount when calculating minimum size
+ - known workarounds:
+ http://article.gmane.org/gmane.comp.kde.cvs/700027
+ http://kdepim.sourcearchive.com/documentation/4.1.80/kleopatra_2conf_2configuredialog_8cpp-source.html
Bugs:
- "cannot create html package index" when installing package as a regular user (due to R.home ("doc") not writable)
Modified: trunk/rkward/rkward/misc/CMakeLists.txt
===================================================================
--- trunk/rkward/rkward/misc/CMakeLists.txt 2009-04-04 21:38:11 UTC (rev 2439)
+++ trunk/rkward/rkward/misc/CMakeLists.txt 2009-04-05 20:49:38 UTC (rev 2440)
@@ -24,20 +24,6 @@
########### install files ###############
-
-
-
-#original Makefile.am contents follow:
-
-#INCLUDES = $(all_includes)
-#METASOURCES = AUTO
-#noinst_LIBRARIES = libmisc.a
-#libmisc_a_SOURCES = rkspinbox.cpp \
-# getfilenamewidget.cpp rkobjectlistview.cpp rkcanceldialog.cpp xmlhelper.cpp \
-# multistringselector.cpp rkcommonfunctions.cpp rkprogresscontrol.cpp rksaveobjectchooser.cpp \
-# rkdummypart.cpp
-#noinst_HEADERS = rkspinbox.h getfilenamewidget.h \
-# rkobjectlistview.h rkcanceldialog.h xmlhelper.h multistringselector.h \
-# rkcommonfunctions.h rkprogresscontrol.h rksaveobjectchooser.h \
-# rkdummypart.h
-#
+INSTALL(FILES
+ rkdummypart.rc
+ DESTINATION ${DATA_INSTALL_DIR}/rkward)
Modified: trunk/rkward/rkward/misc/rkdummypart.cpp
===================================================================
--- trunk/rkward/rkward/misc/rkdummypart.cpp 2009-04-04 21:38:11 UTC (rev 2439)
+++ trunk/rkward/rkward/misc/rkdummypart.cpp 2009-04-05 20:49:38 UTC (rev 2440)
@@ -2,7 +2,7 @@
rkdummypart - description
-------------------
begin : Wed Feb 28 2007
- copyright : (C) 2007 by Thomas Friedrichsmeier
+ copyright : (C) 2007, 2009 by Thomas Friedrichsmeier
email : tfry at users.sourceforge.net
***************************************************************************/
@@ -26,6 +26,8 @@
setWidget (widget);
setComponentData (KGlobal::mainComponent ());
+
+ setXMLFile ("rkdummypart.rc");
}
RKDummyPart::~RKDummyPart () {
Modified: trunk/rkward/rkward/windows/rcontrolwindow.cpp
===================================================================
--- trunk/rkward/rkward/windows/rcontrolwindow.cpp 2009-04-04 21:38:11 UTC (rev 2439)
+++ trunk/rkward/rkward/windows/rcontrolwindow.cpp 2009-04-05 20:49:38 UTC (rev 2440)
@@ -2,7 +2,7 @@
rcontrolwindow - description
-------------------
begin : Wed Oct 12 2005
- copyright : (C) 2005, 2007 by Thomas Friedrichsmeier
+ copyright : (C) 2005, 2007, 2009 by Thomas Friedrichsmeier
email : tfry at users.sourceforge.net
***************************************************************************/
@@ -26,6 +26,7 @@
#include <kmessagebox.h>
#include "../settings/rksettings.h"
+#include "../misc/rkdummypart.h"
#include "../rbackend/rinterface.h"
#include "../rbackend/rcommand.h"
#include "../rbackend/rcommandstack.h"
@@ -38,7 +39,7 @@
RControlWindow::RControlWindow (QWidget *parent, bool tool_window, const char *name) : RKMDIWindow (parent, PendingJobsWindow, tool_window, name) {
RK_TRACE (APP);
- setPart (new RControlWindowPart (this));
+ setPart (new RKDummyPart (0, this));
initializeActivationSignals ();
setFocusPolicy (Qt::ClickFocus);
@@ -153,19 +154,4 @@
RKSettings::configureSettings (RKSettings::PageR, this);
}
-//############# END RContolWindow #######################
-//############# BEGIN RContolWindowPart ###################
-
-RControlWindowPart::RControlWindowPart (RControlWindow *widget) : KParts::Part () {
- RK_TRACE (APP);
-
- setComponentData (KGlobal::mainComponent ());
-
- setWidget (widget);
-}
-
-RControlWindowPart::~RControlWindowPart () {
- RK_TRACE (APP);
-}
-
#include "rcontrolwindow.moc"
Modified: trunk/rkward/rkward/windows/rcontrolwindow.h
===================================================================
--- trunk/rkward/rkward/windows/rcontrolwindow.h 2009-04-04 21:38:11 UTC (rev 2439)
+++ trunk/rkward/rkward/windows/rcontrolwindow.h 2009-04-05 20:49:38 UTC (rev 2440)
@@ -2,7 +2,7 @@
rcontrolwindow - description
-------------------
begin : Wed Oct 12 2005
- copyright : (C) 2005, 2007 by Thomas Friedrichsmeier
+ copyright : (C) 2005, 2007, 2009 by Thomas Friedrichsmeier
email : tfry at users.sourceforge.net
***************************************************************************/
@@ -18,8 +18,6 @@
#ifndef RCONTROLWINDOW_H
#define RCONTROLWINDOW_H
-#include <kparts/part.h>
-
#include <qlabel.h>
#include <QTreeView>
@@ -30,7 +28,6 @@
class RCommandChain;
class RChainOrCommand;
class RControlWindowListViewItem;
-class RControlWindowPart;
/**
\brief Interface to control R command execution
@@ -71,21 +68,4 @@
static RControlWindow *control_window;
};
-/**
- \brief Part interface to RControlWindow
-
-Part interface to RControlWindow
-
- at author Thomas Friedrichsmeier
-*/
-class RControlWindowPart : public KParts::Part {
- Q_OBJECT
-friend class RControlWindow;
-protected:
-/** constructor. */
- RControlWindowPart (RControlWindow *widget);
-/** destructor */
- ~RControlWindowPart ();
-};
-
#endif
This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.
More information about the rkward-tracker
mailing list