[rkward-cvs] SF.net SVN: rkward: [2347] trunk/rkward

[tfry at users.sourceforge.net]

Revision: 2347
          http://rkward.svn.sourceforge.net/rkward/?rev=2347&view=rev
Author:   tfry
Date:     2008-01-24 16:58:07 -0800 (Thu, 24 Jan 2008)

Log Message:
-----------
Better resize handling in progress and R input (readline()) dialogs

Modified Paths:
--------------
    trunk/rkward/ChangeLog
    trunk/rkward/rkward/dialogs/rkreadlinedialog.cpp
    trunk/rkward/rkward/misc/rkprogresscontrol.cpp

Modified: trunk/rkward/ChangeLog
===================================================================
--- trunk/rkward/ChangeLog	2008-01-25 00:03:49 UTC (rev 2346)
+++ trunk/rkward/ChangeLog	2008-01-25 00:58:07 UTC (rev 2347)
@@ -1,3 +1,6 @@
+- Better resize handling in progress and R input (readline()) dialogs
+- Somewhat better handling of the R event loop (esp. when calling "require(not_yet_installed_package)")
+
 --- Version 0.5.0a - Jan-23-2008
 - Fixed: no objects were selectable in most varslots
 - Compilation: check for minimum kdelibs version during cmake stage

Modified: trunk/rkward/rkward/dialogs/rkreadlinedialog.cpp
===================================================================
--- trunk/rkward/rkward/dialogs/rkreadlinedialog.cpp	2008-01-25 00:03:49 UTC (rev 2346)
+++ trunk/rkward/rkward/dialogs/rkreadlinedialog.cpp	2008-01-25 00:58:07 UTC (rev 2347)
@@ -2,7 +2,7 @@
                           rkreadlinedialog  -  description
                              -------------------
     begin                : Fri Sep 15 2006
-    copyright            : (C) 2006, 2007 by Thomas Friedrichsmeier
+    copyright            : (C) 2006, 2007, 2008 by Thomas Friedrichsmeier
     email                : tfry at users.sourceforge.net
  ***************************************************************************/
 
@@ -65,6 +65,7 @@
 		output->setMinimumWidth (screen_width < cwidth ? screen_width : cwidth);
 		output->moveCursor (QTextCursor::End);
 		output->setFocusPolicy (Qt::NoFocus);
+		page->setStretchFactor (output, 10);
 	}
 
 	QLabel *promptl = new QLabel (prompt, page);

Modified: trunk/rkward/rkward/misc/rkprogresscontrol.cpp
===================================================================
--- trunk/rkward/rkward/misc/rkprogresscontrol.cpp	2008-01-25 00:03:49 UTC (rev 2346)
+++ trunk/rkward/rkward/misc/rkprogresscontrol.cpp	2008-01-25 00:58:07 UTC (rev 2347)
@@ -2,7 +2,7 @@
                           rkprogresscontol  -  description
                              -------------------
     begin                : Sun Sep 10 2006
-    copyright            : (C) 2006, 2007 by Thomas Friedrichsmeier
+    copyright            : (C) 2006, 2007, 2008 by Thomas Friedrichsmeier
     email                : tfry at users.sourceforge.net
  ***************************************************************************/
 
@@ -201,6 +201,7 @@
 	setCaption (caption);
 
 	KVBox *vbox = new KVBox (this);
+	vbox->setSizePolicy (QSizePolicy::Fixed, QSizePolicy::Fixed);
 	setMainWidget (vbox);
 
 	QLabel *label = new QLabel (text, vbox);
@@ -228,6 +229,7 @@
 		output_text->setReadOnly (true);
 		output_text->setPlainText (QString ());
 		output_text->setUndoRedoEnabled (false);
+		output_box->setStretchFactor (output_text, 10);
 
 		if (!(mode_flags & RKProgressControl::OutputShownByDefault)) {
 			output_box->hide ();
@@ -264,7 +266,7 @@
 			output_text->setTextColor (Qt::black);
 		} else {
 			output_text->setTextColor (Qt::red);
-			setDetailsWidgetVisible (true);
+			if (!isDetailsWidgetVisible ()) setDetailsWidgetVisible (true);
 			error_indicator->show ();
 		}
 	}


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.