[rkward-cvs] SF.net SVN: rkward: [1912] trunk/rkward

[tfry at users.sourceforge.net]

Revision: 1912
          http://svn.sourceforge.net/rkward/?rev=1912&view=rev
Author:   tfry
Date:     2007-05-16 12:07:09 -0700 (Wed, 16 May 2007)

Log Message:
-----------
Fix the enabledness bug

Modified Paths:
--------------
    trunk/rkward/ChangeLog
    trunk/rkward/rkward/plugin/rkcomponent.cpp

Modified: trunk/rkward/ChangeLog
===================================================================
--- trunk/rkward/ChangeLog	2007-05-16 18:40:29 UTC (rev 1911)
+++ trunk/rkward/ChangeLog	2007-05-16 19:07:09 UTC (rev 1912)
@@ -1,3 +1,4 @@
+- fix some internal problems with enabledness/disabledness of plugin components
 - some complex plotting plugins now start up noticeably faster
 - fixed: sometimes detecting created X11() windows would fail, esp. under high load
 - create the workspace browser only when it is first shown

Modified: trunk/rkward/rkward/plugin/rkcomponent.cpp
===================================================================
--- trunk/rkward/rkward/plugin/rkcomponent.cpp	2007-05-16 18:40:29 UTC (rev 1911)
+++ trunk/rkward/rkward/plugin/rkcomponent.cpp	2007-05-16 19:07:09 UTC (rev 1912)
@@ -155,8 +155,8 @@
 		enabled = false;
 	}
 
+	setEnabled (enabled);	/* We do this, even if the state *seems* to be unchanged. This is needed, as isEnabled () also returns false, if the parent QWidget is not enabled. However, the parent QWidget may not always be the parent component. */
 	if (enabled != isEnabled ()) {
-		setEnabled (enabled);
 		for (QDictIterator<RKComponentBase> it (child_map); it.current (); ++it) {
 			if (it.current ()->isComponent()) {
 				static_cast<RKComponent*> (it.current ())->updateEnablednessRecursive ();


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.