[rkward-cvs] SF.net SVN: rkward: [1209] trunk/rkward/rkward/plugin

tfry at users.sourceforge.net tfry at users.sourceforge.net
Wed Jan 24 17:27:16 UTC 2007


Revision: 1209
          http://svn.sourceforge.net/rkward/?rev=1209&view=rev
Author:   tfry
Date:     2007-01-24 09:27:16 -0800 (Wed, 24 Jan 2007)

Log Message:
-----------
Ouch! The GUI part of a plugin was never really deleted (only hidden). This commit fixes a huge memory leak.

Modified Paths:
--------------
    trunk/rkward/rkward/plugin/rkpreviewbox.cpp
    trunk/rkward/rkward/plugin/rkstandardcomponent.cpp
    trunk/rkward/rkward/plugin/rkstandardcomponentgui.cpp

Modified: trunk/rkward/rkward/plugin/rkpreviewbox.cpp
===================================================================
--- trunk/rkward/rkward/plugin/rkpreviewbox.cpp	2007-01-24 17:18:04 UTC (rev 1208)
+++ trunk/rkward/rkward/plugin/rkpreviewbox.cpp	2007-01-24 17:27:16 UTC (rev 1209)
@@ -72,7 +72,6 @@
 RKPreviewBox::~RKPreviewBox () {
 	RK_TRACE (PLUGIN);
 
-	qDebug ("dtor");
 	killPreview ();
 }
 

Modified: trunk/rkward/rkward/plugin/rkstandardcomponent.cpp
===================================================================
--- trunk/rkward/rkward/plugin/rkstandardcomponent.cpp	2007-01-24 17:18:04 UTC (rev 1208)
+++ trunk/rkward/rkward/plugin/rkstandardcomponent.cpp	2007-01-24 17:27:16 UTC (rev 1209)
@@ -140,7 +140,7 @@
 RKStandardComponent::~RKStandardComponent () {
 	RK_TRACE (PLUGIN);
 
-	qDebug ("sc detor");
+	gui->deleteLater ();
 	delete backend;
 }
 

Modified: trunk/rkward/rkward/plugin/rkstandardcomponentgui.cpp
===================================================================
--- trunk/rkward/rkward/plugin/rkstandardcomponentgui.cpp	2007-01-24 17:18:04 UTC (rev 1208)
+++ trunk/rkward/rkward/plugin/rkstandardcomponentgui.cpp	2007-01-24 17:27:16 UTC (rev 1209)
@@ -144,7 +144,6 @@
 
 	hide ();
 	if (!enslaved) {
-		qDebug ("triggering destruct");
 		component->deleteLater ();
 	}
 }


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.




More information about the rkward-tracker mailing list