[rkward-cvs] SF.net SVN: rkward: [1038] trunk/rkward/rkward/agents

[tfry at users.sourceforge.net]

Revision: 1038
          http://svn.sourceforge.net/rkward/?rev=1038&view=rev
Author:   tfry
Date:     2007-01-02 04:39:48 -0800 (Tue, 02 Jan 2007)

Log Message:
-----------
krazy fixes

Modified Paths:
--------------
    trunk/rkward/rkward/agents/rkloadagent.h
    trunk/rkward/rkward/agents/rksaveagent.h
    trunk/rkward/rkward/agents/showedittextfileagent.h

Modified: trunk/rkward/rkward/agents/rkloadagent.h
===================================================================
--- trunk/rkward/rkward/agents/rkloadagent.h	2007-01-02 12:39:09 UTC (rev 1037)
+++ trunk/rkward/rkward/agents/rkloadagent.h	2007-01-02 12:39:48 UTC (rev 1038)
@@ -30,7 +30,7 @@
 class RKLoadAgent : public QObject, public RCommandReceiver {
 	Q_OBJECT
 public:
-	RKLoadAgent (const KURL &url, bool merge=false);
+	explicit RKLoadAgent (const KURL &url, bool merge=false);
 
 	~RKLoadAgent ();
 protected:

Modified: trunk/rkward/rkward/agents/rksaveagent.h
===================================================================
--- trunk/rkward/rkward/agents/rksaveagent.h	2007-01-02 12:39:09 UTC (rev 1037)
+++ trunk/rkward/rkward/agents/rksaveagent.h	2007-01-02 12:39:48 UTC (rev 1038)
@@ -32,8 +32,8 @@
 public:
 	enum DoneAction { DoNothing=0, Quit=1, Load=2 };
 
-/** creates a new RKSaveAgent. If when_done == Quit, the RKSaveAgent will quit the application as soon as saving was successful (or it asked to by the user). Similarily, if when_done==Load, it will load a new workspace after saving (specify the url in load_url). If url is given (not empty), and not save_file_as, the agent will try to save to the given url, else it will ask the user to specify a url. RKSaveAgent will self destruct when done. */
-	RKSaveAgent (KURL url, bool save_file_as=false, DoneAction when_done=DoNothing, KURL load_url=QString::null);
+/** creates a new RKSaveAgent. If when_done == Quit, the RKSaveAgent will quit the application as soon as saving was successful (or it asked to by the user). Similarly, if when_done==Load, it will load a new workspace after saving (specify the url in load_url). If url is given (not empty), and not save_file_as, the agent will try to save to the given url, else it will ask the user to specify a url. RKSaveAgent will self destruct when done. */
+	explicit RKSaveAgent (KURL url, bool save_file_as=false, DoneAction when_done=DoNothing, KURL load_url=QString::null);
 	
 	~RKSaveAgent ();
 protected:

Modified: trunk/rkward/rkward/agents/showedittextfileagent.h
===================================================================
--- trunk/rkward/rkward/agents/showedittextfileagent.h	2007-01-02 12:39:09 UTC (rev 1037)
+++ trunk/rkward/rkward/agents/showedittextfileagent.h	2007-01-02 12:39:48 UTC (rev 1038)
@@ -23,7 +23,7 @@
 struct RCallbackArgs;
 class ShowEditTextFileDialog;
 
-/** The purpose of this agent is to display text files for showing and/or editing on request of the R backend. Technically speaking, it gets invoked, whenever the standard R callbacks (ptr_)R_ShowFiles, (ptr_)R_EditFiles, or (ptr_)R_EditFile are called. While the task of simply opening such files for display/editing is rather simple, there is one slightly more difficult issue involved (and hence this class to handle it): In standard R, all these calls are blocking further processing, until the user has closed the shown/edited files. In some cases this may be necessary (for instance if R wants to use with the edited files immediately), in some cases this is an unneccessary nuisance (such as when R simply wants to display a help page or some other purely informational text).
+/** The purpose of this agent is to display text files for showing and/or editing on request of the R backend. Technically speaking, it gets invoked, whenever the standard R callbacks (ptr_)R_ShowFiles, (ptr_)R_EditFiles, or (ptr_)R_EditFile are called. While the task of simply opening such files for display/editing is rather simple, there is one slightly more difficult issue involved (and hence this class to handle it): In standard R, all these calls are blocking further processing, until the user has closed the shown/edited files. In some cases this may be necessary (for instance if R wants to use with the edited files immediately), in some cases this is an unnecessary nuisance (such as when R simply wants to display a help page or some other purely informational text).
 
 The solution to this, used in this agent, is to display a non-modal dialog with a "Done"-button, and thereby leave the decision to the user. Whenever the user thinks, it's safe to resume processing, the "Done"-button can be pressed, even if the files are still open. Until that time, processing is halted.
 


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.