[rkward-cvs] SF.net SVN: rkward: [891] trunk/rkward

[tfry at users.sourceforge.net]

Revision: 891
          http://svn.sourceforge.net/rkward/?rev=891&view=rev
Author:   tfry
Date:     2006-10-20 03:35:19 -0700 (Fri, 20 Oct 2006)

Log Message:
-----------
Don't crash when closing a detached window

Modified Paths:
--------------
    trunk/rkward/ChangeLog
    trunk/rkward/TODO
    trunk/rkward/rkward/windows/rkworkplace.cpp

Modified: trunk/rkward/ChangeLog
===================================================================
--- trunk/rkward/ChangeLog	2006-10-19 22:59:24 UTC (rev 890)
+++ trunk/rkward/ChangeLog	2006-10-20 10:35:19 UTC (rev 891)
@@ -1,3 +1,4 @@
+- don't crash when closing a detached window
 - as you type completion of R symbol names in the script editor
 - function argument hinting in the console
 - tab completion of R symbol names in the console

Modified: trunk/rkward/TODO
===================================================================
--- trunk/rkward/TODO	2006-10-19 22:59:24 UTC (rev 890)
+++ trunk/rkward/TODO	2006-10-20 10:35:19 UTC (rev 891)
@@ -14,7 +14,7 @@
 			- Maybe the kate-part needs to be reset (syntax parse tree) every once in a while?
 	- rnorm () and friends auto-print value only once. R_Visible is 0 on subsequent calls (what in the world is going on, here?)
 	- RKEditorDataFrame:
-		- sometimes the current cell idicator (the box around the current cell) gets lost.
+		- sometimes the current cell indicator (the box around the current cell) gets lost.
 			- Navigation and editing is still fine
 			- seems to happen more often with larger data frames
 			- more precisely: seems to happen after scrolling
@@ -34,7 +34,7 @@
 			- if we find out we've already pasted 100 rows, first check, how many more are to come and add this many both to the variable and to the R workspace. Can potentially avoid *lots* of work
 	- Twintable/RKEditorDataFrame
 		- merge the two classes
-		- more efficient syncing: fetch only the values actually needed instead of the whole table
+		- more efficient syncing: fetch only the values actually needed instead of the whole table. How?
 		- make configurable:
 			- invalid color (global and per variable)
 			- unused color (global and per variable)
@@ -52,14 +52,12 @@
 	- RKConsole:
 		- Console should start a command chain when submitting a batch of pasted commands
 		- Better yet, the commands might be autosplit in the backend. Need to think about how to design this correctly, though
-		- hide tabs in console
-		- tabs should do name completion!
 		- Allow pasting at other positions than line end
 		- Prevent cursor from venturing into lines other than the last line
 	- Script editor:
 		- allow to pipe scripts to the console (console might have to be made smarter about large pasted commands, first)
 	- RKConsole / Script editor:
-		- syntax tool tips / code completion
+		- function arg hints in script editor
 		- highlight only valid function names
 	- RKHelpDlg:
 		- in the mid term, this should probably be renamed and moved to windows

Modified: trunk/rkward/rkward/windows/rkworkplace.cpp
===================================================================
--- trunk/rkward/rkward/windows/rkworkplace.cpp	2006-10-19 22:59:24 UTC (rev 890)
+++ trunk/rkward/rkward/windows/rkworkplace.cpp	2006-10-20 10:35:19 UTC (rev 891)
@@ -247,7 +247,7 @@
 	RKMDIWindow *window = static_cast<RKMDIWindow *> (object);
 
 	RK_ASSERT (windows.find (window) != windows.end ());
-	view ()->removePage (window, true);
+	if (window->isAttached ()) view ()->removePage (window, true);
 	windows.remove (window);
 }
 


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.