[rkward-cvs] SF.net SVN: rkward: [831] trunk/rkward

[tfry at users.sourceforge.net]

Revision: 831
          http://svn.sourceforge.net/rkward/?rev=831&view=rev
Author:   tfry
Date:     2006-10-08 16:28:43 -0700 (Sun, 08 Oct 2006)

Log Message:
-----------
Past-midnight thoughts

Modified Paths:
--------------
    trunk/rkward/TODO
    trunk/rkward/rkward/rbackend/rembedinternal.cpp

Modified: trunk/rkward/TODO
===================================================================
--- trunk/rkward/TODO	2006-10-08 22:17:56 UTC (rev 830)
+++ trunk/rkward/TODO	2006-10-08 23:28:43 UTC (rev 831)
@@ -20,7 +20,12 @@
 		- I suppose it's a long jump out of the tryEval context.
 			- do_browser() seems to guard against that. Instead, it's likely that the console io buffer is used, but not set up
 		- investigate why exactly this happens, and whether it's fixable in R or rkward
-	- rnorm () and friends print value only once. R_Visible is 0 on subsequent calls (what in the world is going on, here?)
+		- maybe we can fix this issue (and save other work), by actually running User/Console commands through run_Rmainloop. The command-text would be fed in via R_ReadConsole (would need to keep a buffer). To terminate the loop, we can return 0 there, which should get us out.
+			- How to differentiate readline calls to get new command data from readline calls to get user info?! The prompt may not be realiable enough. Is there other info?
+				- the hist parameter may be a hint, but is also set in do_browser
+				- Does R_ResetConsole play any role in this?
+			- Where would we jump after a SIGINT?
+	- rnorm () and friends auto-print value only once. R_Visible is 0 on subsequent calls (what in the world is going on, here?)
 
 Compilation / technical
 	- Incorporate FreeBSD patches http://www.freshports.org/math/rkward/files.php?message_id=200609172111.k8HLBiob081349@repoman.freebsd.org

Modified: trunk/rkward/rkward/rbackend/rembedinternal.cpp
===================================================================
--- trunk/rkward/rkward/rbackend/rembedinternal.cpp	2006-10-08 22:17:56 UTC (rev 830)
+++ trunk/rkward/rkward/rbackend/rembedinternal.cpp	2006-10-08 23:28:43 UTC (rev 831)
@@ -527,6 +527,7 @@
 	}
 
 	// for safety, let's protect exp for the two print calls below.
+	// TODO: this is not good. It causes an additional PROTECT and UPROTECT. Need to (re-)move printing
 	PROTECT (exp);
 	/* Do NOT ask me why, but the line below is needed for warnings to be printed, while otherwise they would not be shown.
 	Apparently we need to print at least something in order to achieve this. Whatever really happens in Rprintf () to have such an effect, I did not bother to find out. */
@@ -534,7 +535,6 @@
 
 	Rf_PrintWarnings ();
 
-//	SET_SYMVALUE(R_LastvalueSymbol, exp);
 	UNPROTECT (1);		// exp; We unprotect this, as most of the time the caller is not really interested in the result
 	return exp;
 }


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.