D8389: Support Binary Directories With Spaces

[Thomas Friedrichsmeier]

tfry accepted this revision.
tfry added a comment.
This revision is now accepted and ready to land.


  Thanks for the patch. Looks good!
  
  You have commit rights, yourself? If so, could you please cherry-pick to our "frameworks"-branch, as well?

INLINE COMMENTS

> rpackage_install.cmake.in:20
>  		COMMAND @R_EXECUTABLE@ CMD INSTALL ${TIMESTAMPARG} -c -l ${R_LIBDIR} "@CMAKE_CURRENT_SOURCE_DIR@/rkward" "@CMAKE_CURRENT_SOURCE_DIR@/rkwardtests"
> -		WORKING_DIRECTORY @CMAKE_CURRENT_BINARY_DIR@
> +		WORKING_DIRECTORY "@CMAKE_CURRENT_BINARY_DIR@"
>  		RESULT_VARIABLE R_LIB_INSTALL_EXIT_CODE

I have not tried this, just curious: Are the quotes needed at this point, too, or would cmake be smart enough to handle it, here?

REPOSITORY
  R5 RKWard

BRANCH
  workdir-with-spaces

REVISION DETAIL
  https://phabricator.kde.org/D8389

To: narvaez, tfry
Cc: RKWard-Devel-list
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/rkward-devel/attachments/20171021/6309b3f5/attachment.html>