[rkward-devel] indentation conventions

[Thomas Friedrichsmeier]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

On Thu, 18 Dec 2014 11:35:53 +0100
meik michalke <meik.michalke at uni-duesseldorf.de> wrote:
> so far we seem to use tabs for indentation of code. for kdelibs, 4
> spaces instead of one tab is recommended:
>  https://techbase.kde.org/Policies/Kdelibs_Coding_Style
> the same seems to apply for R code (though 2 spaces are also fine):
>  http://cran.r-project.org/web/packages/rockchalk/vignettes/Rstyle.pdf
> 
> is this something we should care about?

For KDE, different projects use different styles, already (and tabs vs.
space are not the only style-question, of course). I'm not particularly
attached to the style we're using, but changing styles is always
somewhat problematic. Importantly, git blame will stop on such changes,
even if the code is otherwise untouched. (Arguably, git gui blame is
comfortable enough to live with this). Either way, I'd vote against
changing this, unless there are compelling reasons, _and_ a very clear
definition of what the new style should be.

For R, the case may in fact be somewhat different, esp. as the
recommended style is also what you get from deparsing / printing R
functions. Not sure, whether it would be possible to use "astyle" to
convert package code, automatically. Adjusting plugin generated code
would probably require some manual work. Sure, tabs can simply be
replaced, but perhaps there are some - few - instances of tabs worth
keeping (inside strings, for example)?

Regards
Thomas
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAEBCAAGBQJUktZCAAoJEDkVkd8YWMu2FQoP/1wZQ64NtCMnvvr11/F2l4gl
0inK9kQ9RiPM/djRCtiKZ5AiC0AbZaZBtU5johr45IBZQUR/Ui5ucvPxT4CQo5VQ
R/asOy2BJ0HQkGqmQhepuSPrp2kmojqvoJ1utodX/Vw40QKnWGPURoi0gMLD8GZt
Fy3kvxbm8jEDYgDlE2D5twlyQ9PPjdL44UB0lFlT/Vnvla/BwSBwaEsnljeGqMjj
nEuM7t+HscRKTVkO6idPHK9YVB4pYxYiunHamZ5B+cSvSf+igcZL0qvoE0ZUPD/+
YwTbkuCku4r5r5ypB7JKCOjTE7JUop/pSTKzF83MXbYwhOzgXNYXafRYBR0amFFj
NbM88xta7frAlfibMfFLz9UOFBfcS4vYP8M5UOGU2H2FFBa0Alry6i/xhtfIXKuK
81Rc3suNV8PaFK3YZoYX7RiqjCqQ1SZg1RqrQK9/225j+cXXjQzDpnW8XrVSNj04
GJteppuxtpvyU9wknawaox88qZbCQIEF5LJzHAIn1X73zSryl/nwCcs0UL/xRKvf
nK30uQ/3Wjxw4kvcc+ed0XCSgf9DhmpiLGOMlc8RQXFxniuulwLGq+rJcD9onU/g
RyHgZKxxBfPhDXANuSGgbQeout9JSTYYgtQtoIVZ6mARBWGtfi5uATrVq33JfExe
YcpjhaSINn85gUtV1bzO
=phGC
-----END PGP SIGNATURE-----