[RkWard-devel] New Plug-ins

[Thomas Friedrichsmeier]

Hi Stefan,

On Sunday 31 December 2006 01:16, SJR wrote:
> I added a bunch of plug-ins for simple distributions normality tests and
> plots. For the normality tests I need is a simple way to check if the data
> are have a certain length. For example for the lillie.test(x) must a
> numeric vector be greater than 4 and for sf.test(x) between 5 and 5000.
>
> Any comments?

In fact we already had some code to check for dimensionality and length, but 
no way to specify this for a varslot, yet. I've just added the following 
attributes to <varslot>:

- num_dimensions
The number of dimensions, an object needs to have. "0" (the default) means, 
any number of dimensions is acceptable. (optional, defaults to "0")

- min_length
The minimum length, an object needs to have in order to be acceptable. 
(optional, defaults to "0")

- max_length
The maximum length, an object needs to have in order to be acceptable. 
(optional, defaults to the largest integer number representable on the 
system)

Is that, what you were looking for?

> @ Thomas please give me some feed back about my changes and plug-ins
> regarding quality and so on.

I haven't looked at the new plugins in details, yet (I will, soon). Some 
rather general comments so far:

1) Will you remember to add ChangeLog entries?
2) When adding new plugin files, we need to make sure to add those to the 
distribution. To do this, follow this procedure:
- cd to the "plugins" directory in your working copy; there should be a 
script "makemakefileam.php"
- run
./makemakefileam.php > Makefile.am
- run make once to make sure the makefile is ok, then commit.
If you don't want to mess with the makefiles, that's ok, and I can do that. In 
that case, please give me a short reminder before the next release, so I 
won't forget.
3) I notice you're doing a lot of cat (HTML_stuff). That method is still 
prevalent in many plugins, but I'd like to get rid of it as much as possible 
for several reasons. For one, it makes the plugin generated code overly large 
and hard to read. Second, it makes it harder to ensure the output formatting 
looks consistent across different plugins. Third, if we ever change the file 
format of our output (to ODF, maybe), this will get us into trouble.
Therefore, when you write

cat ("<h1>Anderson-Darling Normality Test</h1>\n")

it would be better to use this instead:

rk.header ("Anderson-Darling Normality Test")

We don't have a similar means to output results, esp. tables, yet, but I think 
the time has come to create such a function. Something like:

rk.results <- function (vector_of_titles, ...) 

I'll try to come up with something, soon. Just wanted to let you know, 
already.

Regards
Thomas

Happy new Year to all!
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/rkward-devel/attachments/20070101/ff3bcad9/attachment.sig>