Aggressively fixing Flatpak KCM

ivan tkachenko me at ratijas.tk
Wed Mar 22 16:41:54 GMT 2023


Hi,

I'm working on Flatpak KCM.

This is all very broken and we can't do conservative fixes because they 
won't
apply well between master and Plasma/5.27 branches if done little-by-little,
and because the thing is fundamentally broken on multiple levels. I managed
to refactor and rename members, methods and model roles, so they at least
make sense and don't duplicate each other too much. I also started writing
tests and expanding test suite on newly found broken cases and introduced
API. But this is not enough, and on my roadmap there are things like:

- Replacing all section headings from partially(!) translated strings
   strings+enum heuristic into a single (and exposed to QML) enum;
- Rewriting value lists for ComboBox'es from pre-translated QStringList into
   model with text and value roles;
- Rewriting all model setters (both toggling and changing string values) 
from
   storing override data in manually formatted ini/KConfig style string into
   storing proper data structures and value identifiers inside individual
   entries and serializing them in a centralized manner;
- Reading "defaults" not just from metadata, but from other three override
   levels not writable by KCM (system-default, system per-app, 
user-default);
- Fixing model signals, like using beginInsertRows/endInsertRows instead of
   just dataChanged approriately;
- Changing UI styling for entries that are marked for removal, such as
   unchecked non-default filesystems, D-Bus services & prefixes, and
   environment variables
- Implementing default settings highlighter.

Can I please have permission to do aggressive cherry picking from master to
make it better?

-- 
Best,
ivan (@ratijas) tkachenko

-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature
Type: application/pgp-signature
Size: 840 bytes
Desc: OpenPGP digital signature
URL: <http://mail.kde.org/pipermail/release-team/attachments/20230322/a47922b4/attachment.sig>


More information about the release-team mailing list