19.12 Beta releases tarballs are available

Luigi Toscano luigi.toscano at tiscali.it
Mon Nov 18 23:09:52 GMT 2019


Albert Astals Cid ha scritto:
> El divendres, 15 de novembre de 2019, a les 23:43:42 CET, Tobias C. Berner va escriure:
>> Hi there
>>
>> I noticed three issues so far in the tarballs while building:
>> kate: https://people.freebsd.org/~tcberner/logs/kate-19.11.80.log
>> (fails to build, trunk succeeds)
> 
> This one is actually a bit tricky, the problem is that the packaged tarball needs a 
>    find_package(KF5 ${KF5_REQUIRED_VERSION} REQUIRED COMPONENTS I18n)
> on the root CMakeLists.txt otherwise the 
>    ki18n_install(po)
> injected by the packaging scripts will fail.
> 
> I'm proposing bringing it back with a comment so it doesn't get removed again?
> 
> I'm CC'in some people for opinions.

This happened after:
https://commits.kde.org/kate/a167b31210a059d3c57d9c955a759231a2a49d76

I understand the needs for minimizing, but there is no need to move common
dependencies like KI18n (and probably others).

To be totally honest, the scripts from release-tools can handle special cases
like this, and there are two right now (ktp-desktop-applets and kajongg), but
I'd rather have that list removed than extended. I vote for restoring the
search in the top-level file.

Unrelated, but it's worth noting that after the minimization, there is no
check of the Frameworks version, which may be a problem if a feature requires
a specific version - unless I've missed it

Ciao
-- 
Luigi


More information about the release-team mailing list