KHolidays headers (Re: KDE Frameworks 5.49.0)

[David Faure]

On samedi 4 août 2018 18:00:54 CEST Tobias C. Berner wrote:
> Moin moin
> 
> kholidays seems to install the same file twice:
> MD5 (./KF5/KHolidays/kholidays/SunRiseSet) =
> bd0f7b0067f98d7cfc8c998fd0e797d6
> MD5 (./KF5/KHolidays/KHolidays/SunRiseSet) =
> bd0f7b0067f98d7cfc8c998fd0e797d6
> MD5 (./KF5/KHolidays/kholidays/sunriseset.h) =
> 60eebf2d20a81dd8a78e0fcce40adada

Right. Not in the same directory though. Same with all other camelcase headers:

-- Up-to-date: /d/kde/inst/kde_frameworks/include/KF5/KHolidays/kholidays/AstroSeasons
-- Up-to-date: /d/kde/inst/kde_frameworks/include/KF5/KHolidays/kholidays/Holiday
-- Up-to-date: /d/kde/inst/kde_frameworks/include/KF5/KHolidays/kholidays/HolidayRegion
-- Up-to-date: /d/kde/inst/kde_frameworks/include/KF5/KHolidays/kholidays/LunarPhase
-- Up-to-date: /d/kde/inst/kde_frameworks/include/KF5/KHolidays/kholidays/SunRiseSet
-- Up-to-date: /d/kde/inst/kde_frameworks/include/KF5/KHolidays/kholidays/Zodiac

-- Up-to-date: /d/kde/inst/kde_frameworks/include/KF5/KHolidays/KHolidays/AstroSeasons
-- Up-to-date: /d/kde/inst/kde_frameworks/include/KF5/KHolidays/KHolidays/Holiday
-- Up-to-date: /d/kde/inst/kde_frameworks/include/KF5/KHolidays/KHolidays/HolidayRegion
-- Up-to-date: /d/kde/inst/kde_frameworks/include/KF5/KHolidays/KHolidays/LunarPhase
-- Up-to-date: /d/kde/inst/kde_frameworks/include/KF5/KHolidays/KHolidays/SunRiseSet
-- Up-to-date: /d/kde/inst/kde_frameworks/include/KF5/KHolidays/KHolidays/Zodiac

I guess the first set (lowercase destination directory) is incorrect.

But can we stop installing these headers? It shouldn't break anything using KHolidays *correctly*,
but it might break apps that use incorrect includes (like #include <kholidays/Zodiac>) or incorrect
include paths (#include <Zodiac> with only kholidays/ in the include path, but well, linking to KF5Holidays
should bring automatically the right include paths).

-- 
David Faure, faure at kde.org, http://www.davidfaure.fr
Working on KDE Frameworks 5