Breaking the dependency freeze for Okular and KCrash. Worth it?

[Albert Astals Cid]

El diumenge, 8 d’abril de 2018, a les 12:52:29 CEST, Ben Cooksley va escriure:
> On Sun, Apr 8, 2018 at 9:54 PM, Albert Astals Cid <aacid at kde.org> wrote:
> > I just realized that Okular is not linking against KCrash so you don't get
> > all those nice crash dialogs.
> 
> Hi Albert,
> 
> > Patch is one liner
> > https://cgit.kde.org/okular.git/commit/?
> > id=3e25263d7709524e227207092533397ef65f2c82
> > 
> > But it involves a new dependency. Most probably 87.99% of our users
> > already
> > have installed KCrash because something else needs it, but it's a new
> > dependency anyway.
> > 
> > I aws thinking, is it worth to put into the 18.04 branch and break the
> > dependency freeze? Or since okular hopefully doesn't crash that much it's
> > better to just wait for next release?
> 
> Given the benefit of having the crash handler setup I think adding
> KCrash as a dependency should be perfectly fine.
> I imagine most people will have KCrash installed already anyway.

Done.

Cheers,
  Albert

> 
> > Cheers,
> > 
> >   Albert
> 
> Cheers,
> Ben