KGet frameworks branch

[Andrius Štikonas]

Hi,

I think you can commit minor bugfixes directly.

Assuming multiseg is fixed or disabled before final release, I think
we should be able to merge it.

What do others think?

Regards,
Andrius

2017 m. lapkričio 8 d., trečiadienis 15:14:00 GMT Wolfgang Bauer rašė:
> Hi all!
> 
> I spent some time during the last weeks on the KF5 port of kget to fix 
> problems I noticed, e.g. opening the transfer history crashed, the bittorrent 
> plugin wasn't built at all and needed some fixes to actually compile, disabled 
> plugins disappeared from the settings, some incorrect QUrl usage that caused 
> file:/xxx destinations being displayed and a folder hierarchy file:/xxx to be 
> created, ...
> I also ported it from KUniqueApplication to QApplication and KDBusService.
> 
> Review Requests are upcoming, although I assume it's fine to commit minor 
> fixes directly (without review), right?
> 
> The only remaining major problem I'm still facing is that downloads fail to 
> start if the multiseg plugin is enabled (which it is by default). I'll try to 
> investigate and fix this too, but in the worst case it could just be disabled 
> for the 17.12 release...
> Otherwise it seems to work fine here with my local changes (with multiseg 
> disabled and using the normal kio plugin).
> 
> So I'd like to ask: can we merge frameworks to master? AIUI this needs to be 
> done before the dependency freeze tomorrow.
> (my fixes so far don't add any new dependencies anyway, so it should not be a 
> big problem if they are not committed yet)
> 
> PS, two differentials are here, if somebody wants to look at them (reviews 
> would be nice of course ;-) ):
> https://phabricator.kde.org/D8719
> https://phabricator.kde.org/D8724
> 
> Kind Regards,
> Wolfgang
> 
> 
> 


-- 
I encourage the use of end to end email encryption

GPG key:   https://stikonas.eu/andrius.asc
Fingerprint:  1EE5 A320 5904 BAA2 B88C 0A9D 24FD 3194 0095 C0E1
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/release-team/attachments/20171108/d696584d/attachment.sig>