KDE Frameworks 5.34.0

[José Manuel Santamaría Lema]

Hi David,

thank you for adding the missing tarballs and the checks.

I'm doing a test build of the tarballs for Kubuntu and I found an issue with 
the translations fetching code autotesting.

When building from the packages it fails, see the fail.txt attachment of this 
message.

This issue is also reproducible in KDE Neon, see the file adt-output/log from 
adt-output.tar.xz here:
http://build.neon.kde.org/job/xenial_unstable_frameworks_extra-cmake-modules_adt/118/

I think the problem is in the _repository_name function, see the code:
function(_repository_name reponame dir)
    execute_process(COMMAND git config --get remote.origin.url
        OUTPUT_VARIABLE giturl
        RESULT_VARIABLE exitCode
        WORKING_DIRECTORY "${dir}")

    if(exitCode EQUAL 0)
        string(REGEX MATCHALL ".+[:\\/]([-A-Za-z\\d]+)(.git)?\\s*" "" $
{giturl})
        set(${reponame} ${CMAKE_MATCH_1})
    endif()

    if(NOT ${reponame})
        set(${reponame} ${CMAKE_PROJECT_NAME})
    endif()
    set(${reponame} ${${reponame}} PARENT_SCOPE)
endfunction()

So, if I'm understanding correctly the code, when building from the packages, 
it falls back to ${CMAKE_PROJECT_NAME}

Now, if we inspect the tests/KDEFetchTranslations/CMakeLists.txt file, we will 
see this at the top:
project(KDEFetchTranslations)
so I think that's producing the issue.

Could we get this fixed?

Cheers.
-------------- next part --------------
3/49 Test  #3: KDEFetchTranslations ..................................***Failed    1.60 sec
Internal cmake changing into directory: /workspace/build/obj-x86_64-linux-gnu/tests/KDEFetchTranslations
Error: cmake execution failed
The C compiler identification is GNU 5.4.0
The CXX compiler identification is GNU 5.4.0
Check for working C compiler: /usr/bin/cc
Configuring
Check for working C compiler: /usr/bin/cc -- works
Detecting C compiler ABI info
Configuring
Detecting C compiler ABI info - done
Detecting C compile features
Configuring
Configuring
Configuring
Detecting C compile features - done
Check for working CXX compiler: /usr/bin/c++
Configuring
Check for working CXX compiler: /usr/bin/c++ -- works
Detecting CXX compiler ABI info
Configuring
Detecting CXX compiler ABI info - done
Detecting CXX compile features
Configuring
Configuring
Configuring
Detecting CXX compile features - done
module: KDEInstallDirs
module: KDECMakeSettings
Could not set up the appstream test. appstreamcli is missing.
CMake Error at CMakeLists.txt:21 (message):
  Wrong repository name: KDEFetchTranslations, should be
  'extra-cmake-modules'


Configuring
Configuring incomplete, errors occurred!
See also "/workspace/build/obj-x86_64-linux-gnu/tests/KDEFetchTranslations/CMakeFiles/CMakeOutput.log".