Review Request 128223: remove json, appdata and mimetype pos from applications tarball

Albert Astals Cid aacid at kde.org
Mon Jun 20 22:15:28 UTC 2016



> On June 19, 2016, 10:07 p.m., Albert Astals Cid wrote:
> > pack_l10n.sh, line 27
> > <https://git.reviewboard.kde.org/r/128223/diff/1/?file=469118#file469118line27>
> >
> >     This really looks like a very broad naming to be deleting, nowadays we don't have any matching, but i could easily see something like kcm_mimetimes.pot at some point.
> >     
> >     Maybe what we need to do is make scripty complain if he finds a *mimetype* file that it didn't generate?
> 
> Burkhard Lück wrote:
>     we should use a naming scheme indicating that a file is generated by scripty see http://marc.info/?l=kde-i18n-doc&m=146640569414610&w=2

Agreed, do you want to wait until we agree on that?


- Albert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128223/#review96730
-----------------------------------------------------------


On June 20, 2016, 6:21 p.m., Burkhard Lück wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128223/
> -----------------------------------------------------------
> 
> (Updated June 20, 2016, 6:21 p.m.)
> 
> 
> Review request for Release Team and Albert Astals Cid.
> 
> 
> Repository: release-tools
> 
> 
> Description
> -------
> 
> see summary
> 
> 
> Diffs
> -----
> 
>   pack_l10n.sh 5afa5e8 
> 
> Diff: https://git.reviewboard.kde.org/r/128223/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Burkhard Lück
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/release-team/attachments/20160620/1979f753/attachment.html>


More information about the release-team mailing list