Review Request 128223: remove json, appdata and mimetype pos from applications tarball

Albert Astals Cid aacid at kde.org
Sun Jun 19 22:07:50 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128223/#review96730
-----------------------------------------------------------




pack_l10n.sh (line 25)
<https://git.reviewboard.kde.org/r/128223/#comment65352>

    *appdata*.pot ?



pack_l10n.sh (line 26)
<https://git.reviewboard.kde.org/r/128223/#comment65353>

    i'd go 
    json_*_*.pot
    to make it a bit more relisiant to someone introducing a catalog for a library called json_parser



pack_l10n.sh (line 27)
<https://git.reviewboard.kde.org/r/128223/#comment65354>

    This really looks like a very broad naming to be deleting, nowadays we don't have any matching, but i could easily see something like kcm_mimetimes.pot at some point.
    
    Maybe what we need to do is make scripty complain if he finds a *mimetype* file that it didn't generate?


- Albert Astals Cid


On June 17, 2016, 11:42 a.m., Burkhard Lück wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128223/
> -----------------------------------------------------------
> 
> (Updated June 17, 2016, 11:42 a.m.)
> 
> 
> Review request for Release Team and Albert Astals Cid.
> 
> 
> Repository: release-tools
> 
> 
> Description
> -------
> 
> see summary
> 
> 
> Diffs
> -----
> 
>   pack_l10n.sh 5afa5e8 
> 
> Diff: https://git.reviewboard.kde.org/r/128223/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Burkhard Lück
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/release-team/attachments/20160619/582a5f18/attachment.html>


More information about the release-team mailing list