stable sr l10n-kf5 fails to cmake - was - Re: www/sites/www

[Albert Astals Cid]

El dissabte, 3 de desembre de 2016, a les 13:16:16 CET, Chusslove Illich va 
escriure:
> >> [: Antonio Rojas :]
> >> 
> >>   CMake Error at 5/sr/data/CMakeLists.txt:1 (add_subdirectory):
> >>     The source directory
> >>     
> >>       /build/kde-l10n/src/kde-l10n-sr-16.11.90/5/sr/data/_custominstall
> >>     
> >>     does not contain a CMakeLists.txt file.
> > 
> > [: Albert Astals Cid :]
> > You need to either:
> > * Add a dummy CMakeLists.txt file
> > * Go back to the previous situation those files where not in a folder
> > * Somehow teach autogen.sh about folders it has to ignore (that seems
> > less desirable tbh).
> 
> Sorry for the trouble. I moved these custom install files to a
> subdirectory, because Luigi needed some way of recognizing them for
> making applications translation tarballs. Adding dummy CMakeLists.txt
> doesn't work, because autogen.sh deletes it at this depth (it preserves
> them only one level below). The needed change to scripts/autogen.sh is
> small though, what do you say about it?

Seems very hardcoded/specific tbh.

If we're going to go the hardcoding way we may even "properly document 
somewhere" that every folder starting with _ will be ignored or something?

Cheers,
  Albert

> 
>   Index: scripts/autogen.sh
>   ===================================================================
>   --- scripts/autogen.sh  (revision 1476293)
>   +++ scripts/autogen.sh  (working copy)
>   @@ -184,7 +184,7 @@
>            # remove old CMakeLists.txt
>            rm -f $dir/data/CMakeLists.txt;
>            echo "add_subdirectory(data)" >> $dir/CMakeLists.txt
>   -        dirs=`cd $dir/data && find * -maxdepth 0 -type d -not -empty |
> fgrep -v .svn` +        dirs=`cd $dir/data && find * -maxdepth 0 -type d
> -not -empty | fgrep -v .svn | fgrep -v _custominstall` for dir2 in $dirs;
> do
>                echo "add_subdirectory($dir2)" >> $dir/data/CMakeLists.txt
>                rm -f $dir/data/$dir2/CMakeLists.txt;