Review Request 125565: KMail: Fix scrolling up/down on the message viewer

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125565/
-----------------------------------------------------------

(Updated Oct. 9, 2015, 12:31 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDEPIM and Release Team.


Changes
-------

Submitted with commit 9d52b22b3652f4dc274114f41c6ea83a31477c01 by Albert Astals Cid to branch Applications/15.08.


Repository: kdepim


Description
-------

The new style connection for signals does not support default arguments so 

connect(mScrollUpAction, &QAction::triggered,
            q, &Viewer::slotScrollUp);
            
Connects the version of triggered(bool) with slotScrollUp meaning that slotScrollUp always gets a 0 since the action is never checked.

This breaks the API but the widget is only used internally so i think it's something we can live on.

Release-team can we sneak this onto 15.0.8.2 since it's relatively critical?

kdepim guys is there a bug number for this?


Diffs
-----

  messageviewer/viewer/viewer.h 150c24b 
  messageviewer/viewer/viewer.cpp ea4fa75 

Diff: https://git.reviewboard.kde.org/r/125565/diff/


Testing
-------

WOOOOOOOOOOOOORKS


Thanks,

Albert Astals Cid

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/release-team/attachments/20151009/87b830a2/attachment.html>