Review Request 125565: KMail: Fix scrolling up/down on the message viewer

Albert Astals Cid aacid at
Fri Oct 9 00:38:32 UTC 2015

This is an automatically generated e-mail. To reply, visit:

Review request for KDEPIM and Release Team.

Repository: kdepim


The new style connection for signals does not support default arguments so 

connect(mScrollUpAction, &QAction::triggered,
            q, &Viewer::slotScrollUp);
Connects the version of triggered(bool) with slotScrollUp meaning that slotScrollUp always gets a 0 since the action is never checked.

This breaks the API but the widget is only used internally so i think it's something we can live on.

Release-team can we sneak this onto since it's relatively critical?

kdepim guys is there a bug number for this?


  messageviewer/viewer/viewer.h 150c24b 
  messageviewer/viewer/viewer.cpp ea4fa75 




Albert Astals Cid

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the release-team mailing list