Review Request 123907: Make log viewer usable in multiple instances + fix the "KDEInit couldn't launch log viewer" error and Plasma being blocked

[Martin Klapetek]

> On May 26, 2015, 3:40 p.m., Aleix Pol Gonzalez wrote:
> > Wouldn't it help just to remove the: X-DBUS-StartupType=Unique ?
> 
> Aleix Pol Gonzalez wrote:
>     PS: +1 if that's what it takes.

I would have thought so, but it does not work here, Plasma is still blocked, even after logging out and in again.

Actually try it at your machine and see if running it from kicker/kickoff/krunner works then.


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123907/#review80847
-----------------------------------------------------------


On May 26, 2015, 3:30 p.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123907/
> -----------------------------------------------------------
> 
> (Updated May 26, 2015, 3:30 p.m.)
> 
> 
> Review request for Release Team and Telepathy.
> 
> 
> Bugs: 346395
>     http://bugs.kde.org/show_bug.cgi?id=346395
> 
> 
> Repository: ktp-text-ui
> 
> 
> Description
> -------
> 
> This fixes bug 346395 - when it is launched from Plasma, it will block all of Plasma until the app quits, which is announced by an error message box with that "KDEInit couldn't launch" error.
> 
> I'd like to commit this to stable too however this adds a new dependency on KDBusAddons. I think the severity of this issue warrants that new dependency, but can someone from the release team please ack this?
> 
> Additionally it makes it "Multiple" allowing for multiple running instances. I think it can be useful to eg. compare logs, but if anyone has a good reason for why it shouldn't be Multiple, please speak up.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 72c2f8f 
>   logviewer/CMakeLists.txt ac35ff6 
>   logviewer/ktp-log-viewer.desktop 1674566 
>   logviewer/main.cpp 00dbc03 
>   logviewer/org.kde.ktplogviewer.desktop PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/123907/diff/
> 
> 
> Testing
> -------
> 
> Plasma is no longer blocked when the log viewer is launched from Kicker.
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/release-team/attachments/20150526/ed1d3ee3/attachment.html>