Review Request 123074: [KCharSelect] Unbreak KRun powered startup

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123074/#review77787
-----------------------------------------------------------


No, it's a mismatch between the .desktop file and the application code.
The desktop file says "I will register to DBus", and then the application doesn't -> klauncher waits for a bit, then errors.

These apps indeed do not really need to register to DBus, so I would suggest to just remove the DBus-related keys from their desktop files.

This was the way to 'start an app then talk to dbus to it' in the old days (which can be useful for a few of them), but these days dbus-autostart covers that even better. This is why I think we should move away from this (kde-specific) X-DBus-StartupType stuff.

- David Faure


On March 19, 2015, 8:28 p.m., Hrvoje Senjan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123074/
> -----------------------------------------------------------
> 
> (Updated March 19, 2015, 8:28 p.m.)
> 
> 
> Review request for Release Team, Christoph Feck and Laurent Montel.
> 
> 
> Bugs: 344896
>     http://bugs.kde.org/show_bug.cgi?id=344896
> 
> 
> Repository: kcharselect
> 
> 
> Description
> -------
> 
> Due to how desktop file's set up, we need to register to DBus, otherwise klauncher isn't happy.
> Adding Albert due to new dep
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 2276d23 
>   main.cc 2f8c4ba 
> 
> Diff: https://git.reviewboard.kde.org/r/123074/diff/
> 
> 
> Testing
> -------
> 
> The bug is no more.
> 
> 
> Thanks,
> 
> Hrvoje Senjan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/release-team/attachments/20150320/c5d310fe/attachment.html>