Whoopsie in KF5::WindowSystem 5.3.0

[Martin Gräßlin]

On Friday 10 October 2014 17:37:02 Rolf Eike Beer wrote:
> Am Freitag, 10. Oktober 2014, 17:14:41 schrieb Martin Graesslin:
> > Hi all,
> > 
> > unfortunately we have an embarrassing bug [1] in KWindowSystem 5.3.0
> > which can crash any application making use of KWindowSystem on the X11
> > Platform. This is fixed with commit [2]. I recommend to either do a 5.3.1
> > release for KWindowSystem with just that commit added or at least that
> > distros ship the patch in their packages.
> > 
> > Sorry about that. I still don't understand how it could pass through the
> > CI
> > system without failing.
> > 
> > Cheers
> > Martin
> > 
> > [1] Apparently I'm not able to count to four, see BUG 339771
> 
> Why not make the static array static in the file instead of the functions
> and then simply do "netAtomCount = sizeof(array)/sizeof(array[0]) - 1;"?
> That way you never have to count again ;)

My intention was to fix the regression first in the most obvious way that I'm 
only fixing the regression. A change to make the code better should only go 
into 5.4 IMHO.

Cheers
Martin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/release-team/attachments/20141013/2c77b636/attachment.sig>