KF5 beta1 (Re: threadweaver breakage?)

[David Faure]

I have packed up and am uploading beta1, I'm just waiting for this 
threadweaver fix to update threadweaver.

I have to go for most of the day, back around 7pm CET.

On Saturday 29 March 2014 03:08:00 Sebastian Kügler wrote:
> Hi Mirko,
> 
> One of the commits you pushed this week is causing me a crasher. It happens
> when I open Kickoff and start typing. This triggers querying krunner, which
> uses threadweaver -- as you know.
> 
> The relevant portion of the backtrace is:
> 
> #11 0x00007f9e18157c26 in ThreadWeaver::Job::assignQueuePolicy
> (this=0xb931d00, policy=0x7f9db85a3820
> <Plasma::DefaultRunnerPolicy::instance()::policy>) at
> /home/sebas/kf5/src/frameworks/threadweaver/src/job.cpp:167
> #12 0x00007f9db8385510 in Plasma::FindMatchesJob::FindMatchesJob
> (this=0xb931d00, runner=0xb428300, context=0xc1b14e0, parent=0xc17b110) at
> /home/sebas/kf5/src/frameworks/krunner/src/private/runnerjobs.cpp:134
> #13 0x00007f9db8392a39 in Plasma::RunnerManagerPrivate::startJob
> (this=0xc1b14d0, runner=0xb428300) at
> /home/sebas/kf5/src/frameworks/krunner/src/runnermanager.cpp:404
> 
> I've backed out d983947255a and it appears to fix the crasher. (I don't get
> results, but that seems to be a problem, independent of this one.)
> 
> I see two solutions:
> 
> - We revert this change in threadweaver
> - We adapt krunner as needed
> 
> For the second, I'm not familiar with the codebase of krunner, and haven't
> looked how it can be solved there. I'm a bit wary of making changes there,
> because it's on its way out, worked reliably for us so far, and it feels
> generally dangerous to poke around in (for me at least). I'm also a bit
> short on time.
> 
> Anyway, this is a problem for the Plasma Alpha we want to tag today, and
> push out out Tuesday, as it means a crasher in a core feature of the
> desktop, very likely to be triggered.
> 
> Input welcome...

-- 
David Faure, faure at kde.org, http://www.davidfaure.fr
Working on KDE, in particular KDE Frameworks 5