Review Request 116558: Add KAccounts support to the dav resource

Albert Astals Cid aacid at kde.org
Tue Mar 11 00:37:12 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116558/#review52611
-----------------------------------------------------------


With my Release Team member hat i don't oppose to this change ending up in 4.13.

Please wait until wednesday mid-day to see if anyone has any opposing comment and if not feel free to commit it to 4.13 before the Beta 2 tag.

- Albert Astals Cid


On March 6, 2014, 7:55 p.m., Àlex Fiestas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116558/
> -----------------------------------------------------------
> 
> (Updated March 6, 2014, 7:55 p.m.)
> 
> 
> Review request for KDEPIM, Release Team and Grégory Oestreicher.
> 
> 
> Repository: kdepim-runtime
> 
> 
> Description
> -------
> 
> If compiled with KAccounts support and configure to use it, the resource will fetch credentials and host using libaccounts in order to build the urls.
> 
> Support for "editing" is not done, that will be done in 4.14 since it requires better kaccounts-integration.
> 
> To the release team, I would like to add this change to 4.13, it won't do anything except compiled with libaccounts and even so only if the resource is configured to use it.
> 
> 
> Diffs
> -----
> 
>   resources/dav/resource/CMakeLists.txt 14675bc 
>   resources/dav/resource/davgroupwareresource.desktop 2342a01 
>   resources/dav/resource/davgroupwareresource.kcfg 2d25371 
>   resources/dav/resource/settings.h e264866 
>   resources/dav/resource/settings.cpp 12f84cc 
> 
> Diff: https://git.reviewboard.kde.org/r/116558/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Àlex Fiestas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/release-team/attachments/20140311/2b814662/attachment.html>


More information about the release-team mailing list