Review Request 115519: Do not use KDE_VERSION_STRING for workspace applications

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115519/#review49158
-----------------------------------------------------------

Ship it!


If it compiles, makes sense to me :D

- Albert Astals Cid


On Feb. 6, 2014, 3:51 p.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115519/
> -----------------------------------------------------------
> 
> (Updated Feb. 6, 2014, 3:51 p.m.)
> 
> 
> Review request for kde-workspace and Release Team.
> 
> 
> Repository: kde-workspace
> 
> 
> Description
> -------
> 
> Workspace is no longer synced with kdelibs releases. Thus if compiled
> against e.g. 4.12 we want our workspace apps to still be 4.11.
> 
> 
> Diffs
> -----
> 
>   kwin/clients/oxygen/demo/main.cpp 83d9d83 
>   kwrited/kwrited.cpp cab2d6b 
>   plasma/desktop/shell/main.cpp ea3d43d 
>   startkde.cmake 30d5ab5 
>   statusnotifierwatcher/statusnotifierwatcher.cpp 97ae164 
>   systemsettings/app/main.cpp 78109e0 
>   kstyles/oxygen/config/main.cpp 5a5286e 
>   kstyles/oxygen/demo/main.cpp 005395b 
>   ksysguard/gui/ksysguard.cpp 2ad34f2 
>   config-workspace.h.cmake b3ba37d 
>   khotkeys/kcm_hotkeys/kcm_hotkeys.cpp 389a361 
>   kinfocenter/main.cpp c28f7cf 
>   krunner/main.cpp 6eac316 
>   kscreensaver/kblank_screensaver/blankscrn.cpp 99ef649 
>   kscreensaver/krandom_screensaver/random.cpp 4047184 
> 
> Diff: https://git.reviewboard.kde.org/r/115519/diff/
> 
> 
> Testing
> -------
> 
> compiled with 4.12.60 kdelibs and looked at e.g. startkde and systemsettings which have now 4.11.6.
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/release-team/attachments/20140206/91f5e96c/attachment.html>