Review Request 119915: Plasma release scripts to use Ki18n's PO installation macro

[Chusslove Illich]

> On Авг. 25, 2014, 9:02 пре п., Harald Sitter wrote:
> > lib/kdel10n.rb, line 242
> > <https://git.reviewboard.kde.org/r/119915/diff/1/?file=307343#file307343line242>
> >
> >     random nitpicking: could use @languages.empty? instead of a new var

The check should depend on whether there are any translations for the current source directory (in the current method call), while using @languages would leak this information across calls.


On Авг. 25, 2014, 9:02 пре п., Chusslove Illich wrote:
> > The l10n test actually doesn't pass for me:
> > 
> >   1) Failure:
> > TestL10n#test_get_po [./ts_l10n.rb:87]:
> > Failed assertion, no message given.
> > 
> > It appears that the test needs updating since we don't create a million cmakelists.txt anymore.

Done.


- Chusslove


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119915/#review65170
-----------------------------------------------------------


On Авг. 24, 2014, 10:52 по п., Chusslove Illich wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119915/
> -----------------------------------------------------------
> 
> (Updated Авг. 24, 2014, 10:52 по п.)
> 
> 
> Review request for Release Team, Jonathan Riddell and Harald Sitter.
> 
> 
> Repository: releaseme
> 
> 
> Description
> -------
> 
> At present, for installing Plasma PO files the release scripts create CMakeLists.txt files inside po/ directory, which use CMake's GETTEXT_PROCESS_PO_FILES. Ki18n instead provides the KI18N_INSTALL macro that only needs to be called once from the top CMakeLists.txt, with po directory as argument. This patch switches to using it.
> 
> This is in preparation for updating release scripts to also fetch translation scripting modules into the packages. Every PO file can have an associated scripting module (though they are rare). KI18N_INSTALL handles these modules as well, when they are found in expected location inside po/ directory.
> 
> 
> Diffs
> -----
> 
>   lib/cmakeeditor.rb 5465c99 
>   lib/kdel10n.rb f855de8 
>   lib/tests/ts_cmakeeditor.rb 9d7339f 
> 
> Diff: https://git.reviewboard.kde.org/r/119915/diff/
> 
> 
> Testing
> -------
> 
> Run tarme.rb on couple of modules and languages, CMakeLists.txt tree got updated as expected. Run ts_cmakeeditor.rb.
> 
> 
> Thanks,
> 
> Chusslove Illich
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/release-team/attachments/20140830/1c92eaf6/attachment.html>