[kde-workspace/KDE/4.10] kwin: clear m_activeEffects when effects change

Thomas Lübking thomas.luebking at gmail.com
Sat May 4 09:53:36 UTC 2013

Git commit 07d3ac9d8c781755d19c71ccde6d182868a2bfb5 by Thomas Lübking.
Committed on 03/05/2013 at 23:12.
Pushed by luebking into branch 'KDE/4.10'.

clear m_activeEffects when effects change

If a screen with different refreshrate is attached, kwin currently resets
the compositor, altering the effect list.
If at the same time quads are rebuilt, the iteration operates on a pot.
invalid list of dangeling active effects.

Many thanks to Toralf Förster for his testing efforts.

BUG: 308201
FIXED-IN: 4.10.3
REVIEW: 110294
CC: release-team at kde.org

M  +1    -0    kwin/effects.cpp


diff --git a/kwin/effects.cpp b/kwin/effects.cpp
index f99f1a1..112c814 100644
--- a/kwin/effects.cpp
+++ b/kwin/effects.cpp
@@ -1402,6 +1402,7 @@ void EffectsHandlerImpl::reloadEffect(Effect *effect)
 void EffectsHandlerImpl::effectsChanged()
+    m_activeEffects.clear(); // it's possible to have a reconfigure and a quad rebuild between two paint cycles - bug #308201
 //    kDebug(1212) << "Recreating effects' list:";
     foreach (const EffectPair & effect, effect_order) {
 //        kDebug(1212) << effect.first;

More information about the release-team mailing list