kde-workspace 4.10.90 ABI breakage in libtaskmanager

[Albert Astals Cid]

El Dijous, 27 de juny de 2013, a les 21:13:23, Philip Muskovac va escriure:
> On Thursday 27 June 2013 20:08:37 Albert Astals Cid wrote:
> > El Dijous, 27 de juny de 2013, a les 15:52:13, Philip Muskovac va 
escriure:
> > > Hi,
> > > 
> > > b7e30e489f21e09f31e04dab6e8f130764e63671 from Aaron
> > > 
> > >   #MISSING: 4:4.10.90#
> > > 
> > > _ZN11TaskManager4Task12addTransientEmRK10NETWinInfo at ABI_4_3 4:4.8.3 ->
> > > TaskManager::Task::addTransient(unsigned long, NETWinInfo const&)
> > > 
> > > 
> > > and 42c8fde45cfde9cb594d7468c5a91b372cca3664 from Gregor Tätzner
> > > 
> > >   #MISSING: 4:4.10.90#
> > > 
> > > _ZN11TaskManager9BasicMenuC1EP7QWidgetPNS_8TaskItemEPNS_12GroupManagerE5
> > > QLi
> > > stIP7QActionESA_ at ABI_4_3 4:4.8.3 ->
> > > TaskManager::BasicMenu::BasicMenu(QWidget*, TaskManager::TaskItem*,
> > > TaskManager::GroupManager*, QList<QAction*>, QList<QAction*>)
> > > 
> > >   #MISSING: 4:4.10.90#
> > > 
> > > _ZN11TaskManager9BasicMenuC1EP7QWidgetPNS_9TaskGroupEPNS_12GroupManagerE
> > > 5QL
> > > istIP7QActionESA_ at ABI_4_3 4:4.8.3 ->
> > > TaskManager::BasicMenu::BasicMenu(QWidget*, TaskManager::TaskGroup*,
> > > TaskManager::GroupManager*, QList<QAction*>, QList<QAction*>)
> > > 
> > > break the ABI of libtaskmanager.so.4 in 4.10.90.
> > > 
> > > Could we please get those back as KDE_DEPRECATED or instead get the
> > > SOVERSION bumped? Thanks!
> > 
> > Wait, the soname of the library has already been bumped to 4.11, no?
> > 
> > What do you want it bumped to?
> > 
> > Or are you complaining about a ABI break between 4.10.80 and 4.10.90?
> 
> 1) The soversion of the library is '4', that the library version is 4.11.0
> is irrelevant to the ABI versioning. 

right

> I don't know what list describes which
> KDE libraries are public and which private, 

I just told you, kdelibs and kdepimlibs are the only ones we guarantee abi 
stability.

But you are right, if ABI stability is not there soversion has to be bumped.

Cheers,
  Albert

> but the relevant parts of the
> taskmanager API above are shipped and installed by kde-workspace in an
> exported class as 'public:' methods which makes it public API (and there
> are a few third-party taskmanager replacements using it, albeit only a
> few). If you want to keep using the same soversion as the rest of the SC
> please add those symbols back, otherwise the soversion needs to be changed
> to '5'.
> 
> 2) Yes, this happened after 4.10.80 and is only in 4.10.90
> 
> Cheers,
> Philip
> _______________________________________________
> release-team mailing list
> release-team at kde.org
> https://mail.kde.org/mailman/listinfo/release-team