Exception for Nepomuk Ebook Indexers

[Dominik Haumann]

On Thursday, June 20, 2013 20:55:36 Alexander Neundorf wrote:
> On Thursday 20 June 2013, Vishesh Handa wrote:
> > On Thu, Jun 20, 2013 at 7:32 PM, Mario Fux KDE ML <kde-ml at unormal.org>
> 
> wrote:
> > > Am Donnerstag 20 Juni 2013, 14.51:38 schrieb Vishesh Handa:
> > >> Hey guys
> > > 
> > > Morning
> > > 
> > >> I wanted Nepomuk to have some ebook indexers for this release, but I
> > >> never got around to implementing them. I was hoping someone else would
> > >> implement them, since they are so simple, but that never happened.
> > >> 
> > >> Anyway, I spent some time today and implemented both epub and mobi
> > >> analyzers. The epub analyzer uses the libepub library, and for the
> > >> mobipocket analyzers I've just copied the code from
> > >> kdegraphics-mobipocket.
> > > 
> > > I'm not so happy about this part "copied the code". Is it not possible
> > > to
> > > just use it without duplicating the code?
> > 
> > I couldn't see a way this late into the release.
> > 
> > Ideally, kdegraphics-mobipocket should be creating a library and
> > installing it. It currently does not do that. One could make it
> > install the library and the headers, but then there are issues of
> > binary compatibility.
> 
> Copying code is not good.
> OTOH, making code part of a shared library also comes with a cost.
> So I'd say it's probably ok to have the code copied, at least for now.

This is a perfect moment for the infamous quote

  "Temporary workarounds tend to become permanent ones." [1]

Oh well, feel free to ignore my mail, just couldn't resist :-P

Greetings,
Dominik

[1] http://lists.kde.org/?l=kde-core-devel&m=121795820106078