Review Request 109773: New runner that translates words and sentences via Google Translate.

Albert Astals Cid aacid at kde.org
Sat Jun 15 17:41:26 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109773/
-----------------------------------------------------------

(Updated June 15, 2013, 5:41 p.m.)


Review request for Plasma and Release Team.


Changes
-------

Adding the release team, this is a sad situation, the new feature was approved 2 months ago but was uncommited until now and now it's past the feature freeze date. I say it's ok to commit, but i'd like anyone from the release-team to give an extra +1


Description
-------

The Runner uses the Google Translate Homepage and supports all languages provided by Google. It doesn't use the API, because it's not free of charge. 


Diffs
-----

  runners/CMakeLists.txt bb4b491b10e6fef8183a66f55f5d5832dd7bc41a 
  runners/translator/CMakeLists.txt PRE-CREATION 
  runners/translator/plasma-runner-translator.desktop PRE-CREATION 
  runners/translator/translator.h PRE-CREATION 
  runners/translator/translator.cpp PRE-CREATION 
  runners/translator/translatorjob.h PRE-CREATION 
  runners/translator/translatorjob.cpp PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/109773/diff/


Testing
-------


Thanks,

David Baum

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/release-team/attachments/20130615/ddeb3938/attachment.html>


More information about the release-team mailing list