Review Request 110962: Switch to an external LibRaw

Rolf Eike Beer kde at opensource.sf-tec.de
Wed Jun 12 06:39:45 UTC 2013


Vadim Zhukov wrote:

> cmake/modules/FindLibRaw.cmake
> <http://git.reviewboard.kde.org/r/110962/#comment25110>
> 
>     It's probably better to have own prefix for _version_* variables too,
> e.g.: "_libraw_version_major_match".

Pino already said that they are not indended to be used by anyone. And I 
already said that they should simply be unset after using then. Or if they are 
intended for using they should follow the CMake convention about naming them.

Eike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/release-team/attachments/20130612/386c0daa/attachment.sig>


More information about the release-team mailing list