Review Request 111768: Replace Notification by kWarning on missing/unsupported action

[Dario Freddi]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111768/#review36703
-----------------------------------------------------------

Ship it!


No objection - in the longer run, we should definitely rework that part.

- Dario Freddi


On July 28, 2013, 11:01 p.m., Àlex Fiestas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111768/
> -----------------------------------------------------------
> 
> (Updated July 28, 2013, 11:01 p.m.)
> 
> 
> Review request for Release Team, Solid and Dario Freddi.
> 
> 
> Description
> -------
> 
> In 4.11 we are able to detect if an action is supported or not, and if it is not we simply unload it.
> 
> That new behavior makes the notification "Action not found" deprecated since now it is totally possible that a profile tries to load an unsupported action such DimDisplay on most workstations.
> 
> In Powerdevil2/Plasma2/Whatev perhaps we should remove the action from the config, but I'm not sure because an action might be supported during a period of time, for example when plugging a keyboard that support backlight, so it looks to me that we need something more dyamic.
> 
> Release team: This removes a line from the catalog.
> 
> https://bugs.kde.org/show_bug.cgi?id=321508
> https://bugs.kde.org/show_bug.cgi?id=302846
> 
> 
> Diffs
> -----
> 
>   powerdevil/daemon/powerdevilcore.cpp 6874feb 
> 
> Diff: http://git.reviewboard.kde.org/r/111768/diff/
> 
> 
> Testing
> -------
> 
> Notification is not emit anymore.
> 
> 
> Thanks,
> 
> Àlex Fiestas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/release-team/attachments/20130729/ca626c94/attachment.html>