Review Request 111707: Export the value of lidAction (in handleButtonEvents action)
Àlex Fiestas
afiestas at kde.org
Sun Jul 28 12:52:03 UTC 2013
> On July 26, 2013, 5:28 p.m., Albert Astals Cid wrote:
> > int lidAction() const; looks a bit weird as slot signature, but i guess the fact that is a slot is to trick qt4_add_dbus_adaptor?
To make Qt export it on the bus.
- Àlex
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111707/#review36559
-----------------------------------------------------------
On July 26, 2013, 2:58 a.m., Àlex Fiestas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111707/
> -----------------------------------------------------------
>
> (Updated July 26, 2013, 2:58 a.m.)
>
>
> Review request for Release Team, Solid, Kai Uwe Broulik, Dario Freddi, and Oliver Henshaw.
>
>
> Description
> -------
>
> We need to know this value in kscreen so we can act in consequence. We discussed this in the sprint already and everybody was ok.
>
> Release team, can we push this to 4.11? it only exports a value on the bus using a established and standard way of doing it (we use this in 4 more places, exact code).
>
>
> Diffs
> -----
>
> powerdevil/daemon/CMakeLists.txt d0274eb
> powerdevil/daemon/actions/bundled/handlebuttonevents.h a16feba
> powerdevil/daemon/actions/bundled/handlebuttonevents.cpp 78e1d27
> powerdevil/daemon/actions/bundled/powerdevilhandlebuttoneventsaction.desktop 82f3e1b
>
> Diff: http://git.reviewboard.kde.org/r/111707/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Àlex Fiestas
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/release-team/attachments/20130728/92ee51e3/attachment.html>
More information about the release-team
mailing list