Review Request 108516: Do not hardcode site-packages for the python libdir.

[Kevin Kofler]

> On Jan. 22, 2013, 7:27 p.m., Albert Astals Cid wrote:
> > Personally and from a "I know nothing about python" perspective, I'd prefer this to not go to 4.10.0, seems like something a bit fragile that might break and we can't really afford that in 4.10.0 at the moment.
> > 
> > I wouldn't mind seening it in master if you think that fixing the problems that might arise in the future should not be hard.
> > 
> > So could this as a half-shipit.
> > 
> > I'd like Kevin, Luca, Christophe to comment here too, but we can't all get what we want :D

The patch looks right to me (as a non-Python-expert).


- Kevin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108516/#review26009
-----------------------------------------------------------


On Jan. 22, 2013, 7:28 p.m., Michael Jansen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108516/
> -----------------------------------------------------------
> 
> (Updated Jan. 22, 2013, 7:28 p.m.)
> 
> 
> Review request for Build System, Release Team, Christophe Giboudeaux, Kevin Kofler, and Luca Beltrame.
> 
> 
> Description
> -------
> 
> Do not hardcode site-packages for the python libdir.
> 
> 
> Diffs
> -----
> 
>   cmake/modules/FindPythonLibrary.cmake 7cef79b16521c759f38f1deea539a28a50c5d708 
> 
> Diff: http://git.reviewboard.kde.org/r/108516/diff/
> 
> 
> Testing
> -------
> 
> Not much. Works the same as before. Need someone to check on debian. Need someone to check when installing into /usr.
> 
> I think the strequal to check if PYTHON_SITE_PACKAGES_INSTALL_DIR is different from PYTHON_SITE_PACKAGES_DIR is not optimal but good enough. The only problem could be a trailing slash or different case on windows. Any hints to improve it?
> 
> 
> Thanks,
> 
> Michael Jansen
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/release-team/attachments/20130122/ebff0540/attachment.html>