Review Request 108516: Do not hardcode site-packages for the python libdir.
Michael Jansen
kde at michael-jansen.biz
Mon Jan 21 11:01:00 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108516/
-----------------------------------------------------------
Review request for Build System, Release Team and Kevin Kofler.
Description
-------
Do not hardcode site-packages for the python libdir.
Diffs
-----
cmake/modules/FindPythonLibrary.cmake 7cef79b16521c759f38f1deea539a28a50c5d708
Diff: http://git.reviewboard.kde.org/r/108516/diff/
Testing
-------
Not much. Works the same as before. Need someone to check on debian. Need someone to check when installing into /usr.
I think the strequal to check if PYTHON_SITE_PACKAGES_INSTALL_DIR is different from PYTHON_SITE_PACKAGES_DIR is not optimal but good enough. The only problem could be a trailing slash or different case on windows. Any hints to improve it?
Thanks,
Michael Jansen
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/release-team/attachments/20130121/40c17a44/attachment-0001.html>
More information about the release-team
mailing list