Review Request: Fix Save/Don't Save Button in Dialog on Exit, Fixes Regression compared to KDE 4.9

Allen Winter winter at kde.org
Thu Jan 3 20:07:32 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108134/#review24610
-----------------------------------------------------------

Ship it!


looks good to me. no objections, wearing my Release Team hat.

- Allen Winter


On Jan. 3, 2013, 7:38 p.m., Christoph Cullmann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108134/
> -----------------------------------------------------------
> 
> (Updated Jan. 3, 2013, 7:38 p.m.)
> 
> 
> Review request for Kate and Release Team.
> 
> 
> Description
> -------
> 
> Fixes problem that "save" and "don't save" buttons don't work in the dialog that comes up on CTRL-Q if files are changed.
> 
> https://bugs.kde.org/show_bug.cgi?id=311976
> 
> 
> Diffs
> -----
> 
>   kate/app/katesavemodifieddialog.cpp f249bd4 
> 
> Diff: http://git.reviewboard.kde.org/r/108134/diff/
> 
> 
> Testing
> -------
> 
> Patched in master, compiles and works here.
> 
> 
> Thanks,
> 
> Christoph Cullmann
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/release-team/attachments/20130103/6c7e99b8/attachment.html>


More information about the release-team mailing list