Regression of KItemWidgetDelegate in 4.12

[Albert Astals Cid]

El Dimecres, 11 de desembre de 2013, a les 20:20:54, Martin Graesslin va 
escriure:
> On Wednesday 11 December 2013 19:59:51 Albert Astals Cid wrote:
> > Hi guys, seems that 4.12 is hit by a pretty bad regression in
> > KItemWidgetDelegate (patches that don't seem to have been reviewed, but I
> > won't fight that now)
> > 
> > More info at https://bugs.kde.org/show_bug.cgi?id=328528
> > 
> > It seems we're not going to have a fix for today, that is when we are
> > supposed to tag 4.12 packages.
> > 
> > I personally would favor reverting the commits but I don't know if that
> > may
> > break something else so i'm a bit hesitant to do it without Andras
> > comments.> 
> > My suggestion at this point is:
> >  * Tag all the repos tonight as scheduled
> >  * Hope someone fixes the regression before the release in kdelibs and
> > 
> > respin the kdelibs tarball ASAP
> > 
> >  * If the above doesn't happen, delay the release until this gets fixed or
> > 
> > we are convinced we can revert them without breaking something else.
> > 
> > Comments?
> 
> given that also a bug fix could introduce another regression I would suggest
> to introduce another RC once a fix is present and thus delay the release by
> another week.

I am hoping that Andras would let us just revert his changes since reading the 
commit logs seems like they are only optimizations that ended up wrong (i.e. i 
hope he wasn't really doing any bugfix).

If not what you suggest makes sense *but* that'd mean releasing on Xmas day.

I'm *not* going to be around to do that. If anyone wants to volunteer...

Cheers,
  Albert

> 
> Cheers
> Martin