Review Request 111947: Backup Statement Generator: statements without a datatype can be valid
David Edmundson
david at davidedmundson.co.uk
Thu Aug 8 21:42:20 UTC 2013
> On Aug. 8, 2013, 8:56 p.m., Albert Astals Cid wrote:
> > I can confirm that the new test fails without the patch and works with it. I can't assess the correctness of the code itself since my nepomuk-foo ? 0
> >
> > It'd be cool if someone else from nepomuk-land can try to review. If not I'll guess we'll have to trust Vishesh and commit it :-)
The change seems legit. Ship it from me.
- David
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111947/#review37383
-----------------------------------------------------------
On Aug. 8, 2013, 7:05 p.m., Vishesh Handa wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111947/
> -----------------------------------------------------------
>
> (Updated Aug. 8, 2013, 7:05 p.m.)
>
>
> Review request for Nepomuk and Release Team.
>
>
> Description
> -------
>
> Backup Statement Generator: statements without a datatype can be valid
>
> In Nepomuk the nao:description is stored as an rdfs literal, which means
> it doesn't have a datatype, but is supposed to have a language tag.
> Since we don't store the language tag, it is just stored as a string.
> This used to be considered invalid by the statement generator and
> therefore the nao:description (dolphin comments) was never backed up
> even though it was requested.
>
> BUG: 323260
>
> It's important to get this into 4.11 otherwise everyone will loose their comments on installing 4.11 as the migration is done through backup.
>
>
> This addresses bug 323260.
> http://bugs.kde.org/show_bug.cgi?id=323260
>
>
> Diffs
> -----
>
> services/storage/backup/statementgenerator.cpp c3b5985
> autotests/test/backuptests.cpp 7284dd6
>
> Diff: http://git.reviewboard.kde.org/r/111947/diff/
>
>
> Testing
> -------
>
> Tested by manually backing up a number of times.
>
>
> Thanks,
>
> Vishesh Handa
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/release-team/attachments/20130808/d6f4279b/attachment.html>
More information about the release-team
mailing list