Review Request 111947: Backup Statement Generator: statements without a datatype can be valid

[Vishesh Handa]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111947/
-----------------------------------------------------------

(Updated Aug. 8, 2013, 7:05 p.m.)


Review request for Nepomuk and Release Team.


Changes
-------

Added a unit test


Description
-------

    Backup Statement Generator: statements without a datatype can be valid
    
    In Nepomuk the nao:description is stored as an rdfs literal, which means
    it doesn't have a datatype, but is supposed to have a language tag.
    Since we don't store the language tag, it is just stored as a string.
    This used to be considered invalid by the statement generator and
    therefore the nao:description (dolphin comments) was never backed up
    even though it was requested.
    
    BUG: 323260

It's important to get this into 4.11 otherwise everyone will loose their comments on installing 4.11 as the migration is done through backup.


This addresses bug 323260.
    http://bugs.kde.org/show_bug.cgi?id=323260


Diffs (updated)
-----

  services/storage/backup/statementgenerator.cpp c3b5985 
  autotests/test/backuptests.cpp 7284dd6 

Diff: http://git.reviewboard.kde.org/r/111947/diff/


Testing
-------

Tested by manually backing up a number of times.


Thanks,

Vishesh Handa

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/release-team/attachments/20130808/bb1d38bf/attachment.html>