Request for adding new plugin for Dolphin

[Frank Reininghaus]

Hi Albert,

2012/11/9 Albert Astals Cid:
> El Divendres, 9 de novembre de 2012, a les 15:43:05, Frank Reininghaus va
> escriure:
>> Hi Albert,
>>
>> 2012/11/8 Albert Astals Cid:
>> > El Dijous, 8 de novembre de 2012, a les 09:04:15, Frank Reininghaus va
>> >
>> > escriure:
>> >> Hi Friedrich,
>> >>
>> >> 2012/11/6 Friedrich W. H. Kossebau:
>> >> > Hi,
>> >> >
>> >> > Am Montag, 5. November 2012, 21:50:01 schrieb Albert Astals Cid:
>> >> >> El Dilluns, 5 de novembre de 2012, a les 20:47:51, Martin Andersen va
>> >> >>
>> >> >> escriure:
>> >> >> > On Mon, Nov 5, 2012 at 8:00 PM, Albert Astals Cid <aacid at kde.org>
>> >
>> > wrote:
>> >> >> > > El Diumenge, 4 de novembre de 2012, a les 19:05:57, Martin
>> >> >> > > Andersen
>> >> >> > > va
>> >> >> > >
>> >> >> > > escriure:
>> >> >> > > > Hi,
>> >> >> > >
>> >> >> > > Hi
>> >> >> > >
>> >> >> > > > I have made a Perforce version control plugin for Dolphin [1].
>> >> >> > > >
>> >> >> > > > I know that we are in soft feature freeze. Will it be possible
>> >> >> > > > to
>> >> >> > > > include
>> >> >> > > > this plugin in KDE 4.10? This request is supported by Frank
>> >> >> > > > Reininghaus.
>> >> >> > >
>> >> >> > > What's the intended destination (as in repo)?
>> >> >> >
>> >> >> > http://websvn.kde.org/trunk/KDE/kdesdk/dolphin-plugins/
>> >> >> >
>> >> >> > > What's the impact if the code was horribly wrong and crashy? Would
>> >> >> > > it
>> >> >> > > crash
>> >> >> > > dolphin all the time? Or just when perforce was used? Or when you
>> >> >> > > entered
>> >> >> > > a
>> >> >> > > folder that is a perforce checkout?
>> >> >> >
>> >> >> > It will have no impact if the plugin is dissabled.
>> >> >> > When the plugin is enabled the constructor will be called and the
>> >> >> > function
>> >> >> > FileViewPerforcePlugin::fileName() will be called.
>> >> >> > Only when entering a folder under perforce control the remaining
>> >> >> > code
>> >> >> > will
>> >> >> > be active.
>> >> >>
>> >> >> No objection from me. At least you'd need kdesdk coordinator approval
>> >> >> too.
>> >> >> Friedrich are you reading this?
>> >> >
>> >> > Will have a look until Friday.
>> >>
>> >> Martin created a review request:
>> >>
>> >> https://svn.reviewboard.kde.org/r/7049/
>> >>
>> >> From my point of view, the plugin is suitable for inclusion in KDE
>> >> 4.10, but it would be nice if you could have a look.
>> >
>> > Can we please follow the rules as specified at
>> > http://techbase.kde.org/Policies/Application_Lifecycle#Stage_2:_Stable for
>> > projects going through kdereview and notify also kde-core-devel?
>>
>> I see your point, but either it is not entirely clear to me what the
>> review rules are for things which are not applications or libraries of
>> their own, but rather parts of/plugins for them, or those rules are
>> ignored all the time.
>
> Yes, people ignore stuff, which results in broken i18n and stuff like it that
> people tend to not care much about.

Yes, I can imagine that it can be frustrating to see people break
important stuff like i18n all the time, and I really admire your
patience when you tell people for the millionth time to add a
Messages.sh :-) Your work is really much appreciated!

> From my POV if it is a new self contained unit, be it an application, library
> or plugin it should follow the rules and tell the wider world there is new
> stuff we are going to ship and if they care to have a look. Review *is a good
> thing*, improves code and hopefully will make people have a more common
> ownership of stuff if they have a look at the code.

Of course review is a good thing, and Martin's review request did
already get a couple of suggestions for improvements. It just wasn't
clear to me if telling the wider world is required/makes sense in this
case, or if having it reviewed by the people who work on the area is
enough - I think that not everyone reading kde-core-devel wants to be
informed about every little thing. But actually, either way is fine
for me. However, seeing that the hard feature freeze is already in
place, it might have to wait until KDE/4.10 branches are created
anyway.

Best regards,
Frank