Request for adding new plugin for Dolphin

[Frank Reininghaus]

Hi Albert,

2012/11/8 Albert Astals Cid:
> El Dijous, 8 de novembre de 2012, a les 09:04:15, Frank Reininghaus va
> escriure:
>> Hi Friedrich,
>>
>> 2012/11/6 Friedrich W. H. Kossebau:
>> > Hi,
>> >
>> > Am Montag, 5. November 2012, 21:50:01 schrieb Albert Astals Cid:
>> >> El Dilluns, 5 de novembre de 2012, a les 20:47:51, Martin Andersen va
>> >>
>> >> escriure:
>> >> > On Mon, Nov 5, 2012 at 8:00 PM, Albert Astals Cid <aacid at kde.org>
> wrote:
>> >> > > El Diumenge, 4 de novembre de 2012, a les 19:05:57, Martin Andersen
>> >> > > va
>> >> > >
>> >> > > escriure:
>> >> > > > Hi,
>> >> > >
>> >> > > Hi
>> >> > >
>> >> > > > I have made a Perforce version control plugin for Dolphin [1].
>> >> > > >
>> >> > > > I know that we are in soft feature freeze. Will it be possible to
>> >> > > > include
>> >> > > > this plugin in KDE 4.10? This request is supported by Frank
>> >> > > > Reininghaus.
>> >> > >
>> >> > > What's the intended destination (as in repo)?
>> >> >
>> >> > http://websvn.kde.org/trunk/KDE/kdesdk/dolphin-plugins/
>> >> >
>> >> > > What's the impact if the code was horribly wrong and crashy? Would it
>> >> > > crash
>> >> > > dolphin all the time? Or just when perforce was used? Or when you
>> >> > > entered
>> >> > > a
>> >> > > folder that is a perforce checkout?
>> >> >
>> >> > It will have no impact if the plugin is dissabled.
>> >> > When the plugin is enabled the constructor will be called and the
>> >> > function
>> >> > FileViewPerforcePlugin::fileName() will be called.
>> >> > Only when entering a folder under perforce control the remaining code
>> >> > will
>> >> > be active.
>> >>
>> >> No objection from me. At least you'd need kdesdk coordinator approval
>> >> too.
>> >> Friedrich are you reading this?
>> >
>> > Will have a look until Friday.
>>
>> Martin created a review request:
>>
>> https://svn.reviewboard.kde.org/r/7049/
>>
>> From my point of view, the plugin is suitable for inclusion in KDE
>> 4.10, but it would be nice if you could have a look.
>
> Can we please follow the rules as specified at
> http://techbase.kde.org/Policies/Application_Lifecycle#Stage_2:_Stable for
> projects going through kdereview and notify also kde-core-devel?

I see your point, but either it is not entirely clear to me what the
review rules are for things which are not applications or libraries of
their own, but rather parts of/plugins for them, or those rules are
ignored all the time.

I'm thinking of the existing Dolphin plugins, which were, to my
knowledge, not in kdereview and not discussed on k-c-d either (please
correct me if I'm wrong). Or the new Solid udisks2 backend in KDE
4.10, which I've never seen discussed on k-c-d (again, please correct
me if I'm wrong), but which, according to what people tell me now [1]
may considerably slow down Dolphin startup in certain not-so-uncommon
use cases if we don't implement our own asynchronous wrapper around
Solid.

But if there are rules, I fully agree with you that they should be followed.

Best regards,
Frank

[1] https://git.reviewboard.kde.org/r/107168/