Request for adding new plugin for Dolphin

[Frank Reininghaus]

Hi Friedrich,

2012/11/6 Friedrich W. H. Kossebau:
> Hi,
>
> Am Montag, 5. November 2012, 21:50:01 schrieb Albert Astals Cid:
>> El Dilluns, 5 de novembre de 2012, a les 20:47:51, Martin Andersen va
>>
>> escriure:
>> > On Mon, Nov 5, 2012 at 8:00 PM, Albert Astals Cid <aacid at kde.org> wrote:
>> > > El Diumenge, 4 de novembre de 2012, a les 19:05:57, Martin Andersen va
>> > >
>> > > escriure:
>> > > > Hi,
>> > >
>> > > Hi
>> > >
>> > > > I have made a Perforce version control plugin for Dolphin [1].
>> > > >
>> > > > I know that we are in soft feature freeze. Will it be possible to
>> > > > include
>> > > > this plugin in KDE 4.10? This request is supported by Frank
>> > > > Reininghaus.
>> > >
>> > > What's the intended destination (as in repo)?
>> >
>> > http://websvn.kde.org/trunk/KDE/kdesdk/dolphin-plugins/
>> >
>> > > What's the impact if the code was horribly wrong and crashy? Would it
>> > > crash
>> > > dolphin all the time? Or just when perforce was used? Or when you
>> > > entered
>> > > a
>> > > folder that is a perforce checkout?
>> >
>> > It will have no impact if the plugin is dissabled.
>> > When the plugin is enabled the constructor will be called and the function
>> > FileViewPerforcePlugin::fileName() will be called.
>> > Only when entering a folder under perforce control the remaining code will
>> > be active.
>>
>> No objection from me. At least you'd need kdesdk coordinator approval too.
>> Friedrich are you reading this?
>
> Will have a look until Friday.

Martin created a review request:

https://svn.reviewboard.kde.org/r/7049/

>From my point of view, the plugin is suitable for inclusion in KDE
4.10, but it would be nice if you could have a look.

Best regards,
Frank