Review Request: ResourceManager: Do not double initalize the NepomukMainModel
Vishesh Handa
me at vhanda.in
Tue Jun 26 09:06:14 UTC 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105281/
-----------------------------------------------------------
(Updated June 26, 2012, 9:06 a.m.)
Review request for Nepomuk, Release Team and Sebastian Trueg.
Changes
-------
Adding the 'release-team' to the groups as I missed the RC1 freeze. This change is very very trivial, but they sent an email saying they want to be informed.
Description
-------
ResourceManager: Do not double initalize the NepomukMainModel
The NepomukMainModel is initalized once when it is created and then the
second time in ResourceManager::init.
This results in a second connection being made to nepomukstorage, and an
extra thread being spawned over there. The old thread is eventually
deleted, but the whole process is rather pointless.
Diffs
-----
libnepomukcore/resource/nepomukmainmodel.cpp a11faae9a6d42806ba884e74f07e2d0113c6910f
Diff: http://git.reviewboard.kde.org/r/105281/diff/
Testing
-------
Thanks,
Vishesh Handa
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/release-team/attachments/20120626/3f30f9c9/attachment.html>
More information about the release-team
mailing list