Review Request: Do no depend on kdelibs Nepomuk

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105766/#review16674
-----------------------------------------------------------


Can anyone explain why this is really needed for windows? 

I understand that those removed includes are wrong/not needed, but why do they make the build fail?

- Albert Astals Cid


On July 28, 2012, 12:09 p.m., Vishesh Handa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105766/
> -----------------------------------------------------------
> 
> (Updated July 28, 2012, 12:09 p.m.)
> 
> 
> Review request for Nepomuk, Release Team, Patrick Spendrin, and Sebastian Trueg.
> 
> 
> Description
> -------
> 
>     Do no depend on kdelibs Nepomuk
>     
>     * Removed find_package(Nepomuk REQUIRED), and other unnecessary commands
>     * We do not need to include NEPOMUK_INCLUDE_DIR in the list of includes
> 
> @Release-Team: Apparently needed for Windows.
> 
> 
> Diffs
> -----
> 
>   server/CMakeLists.txt 9635f22 
>   services/backupsync/gui/CMakeLists.txt 02800d3 
>   services/backupsync/gui/guitest/CMakeLists.txt 146ba3a 
>   services/backupsync/lib/CMakeLists.txt 769a116 
>   services/backupsync/lib/test/CMakeLists.txt 55d0af7 
>   services/backupsync/service/CMakeLists.txt 6fa785c 
>   services/fileindexer/CMakeLists.txt 60d9b36 
>   services/fileindexer/indexer/CMakeLists.txt 38b46c8 
>   services/fileindexer/test/CMakeLists.txt 4e66e7b 
>   services/filewatch/CMakeLists.txt fd5d710 
>   services/storage/test/CMakeLists.txt cbef45e 
>   servicestub/CMakeLists.txt 88b24aa 
> 
> Diff: http://git.reviewboard.kde.org/r/105766/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Vishesh Handa
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/release-team/attachments/20120730/d45f06bd/attachment.html>