Review Request: Remove the Thing class
Albert Astals Cid
tsdgeos at terra.es
Mon Jul 30 18:16:12 UTC 2012
> On July 28, 2012, 12:36 p.m., Vishesh Handa wrote:
> > I have just been informed that the tarballs for nepomuk-core have already been spun. Could we please please re-spin them, and include this patch. I don't care about the rest. They are just bug fixes.
> >
> > This one removes an entire class, and if KDE 4.9, goes out without this patch, I can never remove it. Not until Frameworks.
What about things like kde-runtime/nepomuk/kioslaves/nepomuk/kio_nepomuk.cpp ?
- Albert
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105755/#review16568
-----------------------------------------------------------
On July 27, 2012, 2:37 p.m., Vishesh Handa wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105755/
> -----------------------------------------------------------
>
> (Updated July 27, 2012, 2:37 p.m.)
>
>
> Review request for Nepomuk, Release Team and Sebastian Trueg.
>
>
> Description
> -------
>
> No one uses it, and the same class can be generated using the rcgen.
> I don't see the point of having this class.
>
> This is my last chance to remove this old code. Otherwise I'll have to wait till KDE Frameworks 5.
>
>
> Diffs
> -----
>
> includes/CMakeLists.txt 4ac2d7c
> includes/Thing 952544e
> libnepomukcore/CMakeLists.txt 066c898
> libnepomukcore/resource/thing.h 2ae3d75
> libnepomukcore/resource/thing.cpp 59f2a4d
>
> Diff: http://git.reviewboard.kde.org/r/105755/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Vishesh Handa
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/release-team/attachments/20120730/bb35d079/attachment.html>
More information about the release-team
mailing list